Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 8702017: Indicate to that textures passed to GVDA are cleared by the decoder. (Closed)

Created:
9 years ago by Ami GONE FROM CHROMIUM
Modified:
9 years ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, jam, acolwell+watch_chromium.org, annacc+watch_chromium.org, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, vrk (LEFT CHROMIUM), scherkus (not reviewing), ihf+watch_chromium.org
Visibility:
Public.

Description

Indicate to that textures passed to GVDA are cleared by the decoder. This is required by CL 108226; without this textures that were created with TexImage2D(..., NULL) (i.e. pixels==NULL) get cleared right before being rendered, *after* they've been drawn to by the decoder. BUG=104579 TEST=trybots. Also, gles2 works again (as does the nascent <video> HW video decode being developed for the bug above) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113046

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ami GONE FROM CHROMIUM
This is the result of (internal) thread http://go/nf2/#!topic/chrome-gpu/qJWxu9UM5Cs
9 years ago (2011-11-25 19:13:54 UTC) #1
Ami GONE FROM CHROMIUM
apatrick: ping? (in case this review got buried during your cold)
9 years ago (2011-12-03 02:14:31 UTC) #2
apatrick_chromium
Sorry for the delay. LGTM.
9 years ago (2011-12-05 19:23:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fischman@chromium.org/8702017/1
9 years ago (2011-12-05 20:09:46 UTC) #4
commit-bot: I haz the power
9 years ago (2011-12-05 22:33:50 UTC) #5
Change committed as 113046

Powered by Google App Engine
This is Rietveld 408576698