Add device status reports to policy requests.

chrome/browser/policy/device_status_collector_unittest.cc

Index: chrome/browser/policy/device_status_collector_unittest.cc
diff --git a/chrome/browser/policy/device_status_collector_unittest.cc b/chrome/browser/policy/device_status_collector_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..f89d9fc8436181a59c9960588e3b3a7bbae452bc
--- /dev/null
+++ b/chrome/browser/policy/device_status_collector_unittest.cc
@@ -0,0 +1,222 @@
+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/policy/device_status_collector.h"
+
+#include "base/time.h"
+#include "chrome/browser/idle.h"
+#include "chrome/browser/policy/proto/device_management_backend.pb.h"
+#include "chrome/browser/prefs/pref_service.h"
+#include "chrome/test/base/testing_pref_service.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+using base::TimeDelta;
+using base::Time;
+
+namespace em = enterprise_management;
+
+namespace {
+
+class TestingDeviceStatusCollector : public policy::DeviceStatusCollector {
+ public:
+  explicit TestingDeviceStatusCollector(PrefService* local_state)
+    :  policy::DeviceStatusCollector(local_state),
+       local_state_(local_state),
+       baseline_time_(Time::Now()) {
+  }
+
+  void Simulate(IdleState* states, int len) {
+    for (int i = 0; i < len; i++)
+      IdleStateCallback(states[i]);
+  }
+
+  void SimulateWithSleep(IdleState* states, int len, int ) {
+    for (int i = 0; i < len; i++)
+      IdleStateCallback(states[i]);
+  }
+
+  virtual unsigned int max_stored_active_periods() const OVERRIDE {
+    return 10; // Artificially low number for testing purposes.
+  }
+
+ protected:
+  virtual void CheckIdleState() OVERRIDE {
+    // This should never be called in testing, as it results in a dbus call.
+    NOTREACHED();
+  }
+
+  // Each time this is called, returns a time that is a fixed increment
+  // later than the previous time.
+  virtual Time GetCurrentTime() OVERRIDE {
+    static int call_count = 0;
+    return baseline_time_ + TimeDelta::FromSeconds(
+        policy::DeviceStatusCollector::kPollIntervalSeconds * call_count++);
+  }
+
+ private:
+  PrefService* local_state_;
+
+  // Baseline time for the fake times returned from GetCurrentTime().
+  // It doesn't really matter what this is, as long as it stays the same over
+  // the lifetime of the object.
+  Time baseline_time_;
+};
+
+}

[Mattias Nissler (ping if slow), 2011/11/30 12:44:29]

// namespace

[Patrick Dubroy, 2011/12/06 14:30:36]

Done.

+
+namespace policy {
+
+// Return the total number of active milliseconds contained in a device
+// status report.
+int64 GetActiveMilliseconds(em::DeviceStatusReportRequest& status) {
+  int64 active_milliseconds = 0;
+  for (int i = 0; i < status.active_time_size(); i++) {
+    const em::TimePeriod& period = status.active_time(i);
+    active_milliseconds += period.end_timestamp() - period.start_timestamp();
+  }
+  return active_milliseconds;
+}
+
+class DeviceStatusCollectorTest : public testing::Test {
+ public:
+  DeviceStatusCollectorTest()
+    :  prefs_(),
+       status_collector_(&prefs_) {
+    DeviceStatusCollector::RegisterPrefs(&prefs_);
+  }
+
+ protected:
+  // Convenience method.
+  int64 ActivePeriodMilliseconds() {
+    return policy::DeviceStatusCollector::kPollIntervalSeconds * 1000;
+  }
+
+  TestingPrefService prefs_;
+  TestingDeviceStatusCollector status_collector_;
+  em::DeviceStatusReportRequest status_;
+};
+
+TEST_F(DeviceStatusCollectorTest, AllIdle) {
+  IdleState test_states[] = {
+    IDLE_STATE_IDLE,
+    IDLE_STATE_IDLE,
+    IDLE_STATE_IDLE
+  };
+  // Test reporting with no data.
+  status_collector_.GetStatus(&status_);
+  EXPECT_EQ(0, status_.active_time_size());
+  EXPECT_EQ(0, GetActiveMilliseconds(status_));
+
+  // Test reporting with a single idle sample.
+  status_collector_.Simulate(test_states, 1);
+  status_collector_.GetStatus(&status_);
+  EXPECT_EQ(0, status_.active_time_size());
+  EXPECT_EQ(0, GetActiveMilliseconds(status_));
+
+  // Test reporting with multiple consecutive idle samples.
+  status_collector_.Simulate(test_states,
+                             sizeof(test_states) / sizeof(IdleState));
+  status_collector_.GetStatus(&status_);
+  EXPECT_EQ(0, status_.active_time_size());
+  EXPECT_EQ(0, GetActiveMilliseconds(status_));
+}
+
+TEST_F(DeviceStatusCollectorTest, AllActive) {
+  IdleState test_states[] = {
+    IDLE_STATE_ACTIVE,
+    IDLE_STATE_ACTIVE,
+    IDLE_STATE_ACTIVE
+  };
+  // Test a single active sample.
+  status_collector_.Simulate(test_states, 1);
+  status_collector_.GetStatus(&status_);
+  EXPECT_EQ(1, status_.active_time_size());
+  EXPECT_EQ(1 * ActivePeriodMilliseconds(), GetActiveMilliseconds(status_));
+  status_.clear_active_time(); // Clear the result protobuf.
+
+  // Test multiple consecutive active samples -- they should be coalesced
+  // into a single active period.
+  status_collector_.Simulate(test_states,
+                             sizeof(test_states) / sizeof(IdleState));
+  status_collector_.GetStatus(&status_);
+  EXPECT_EQ(1, status_.active_time_size());
+  EXPECT_EQ(3 * ActivePeriodMilliseconds(), GetActiveMilliseconds(status_));
+}
+
+TEST_F(DeviceStatusCollectorTest, MixedStates) {
+  IdleState test_states[] = {
+    IDLE_STATE_ACTIVE,
+    IDLE_STATE_IDLE,
+    IDLE_STATE_ACTIVE,
+    IDLE_STATE_ACTIVE,
+    IDLE_STATE_IDLE,
+    IDLE_STATE_IDLE,
+    IDLE_STATE_ACTIVE
+  };
+  status_collector_.Simulate(test_states,
+                             sizeof(test_states) / sizeof(IdleState));
+  status_collector_.GetStatus(&status_);
+  EXPECT_EQ(3, status_.active_time_size());
+  EXPECT_EQ(4 * ActivePeriodMilliseconds(), GetActiveMilliseconds(status_));
+}
+
+TEST_F(DeviceStatusCollectorTest, StateKeptInPref) {
+  IdleState test_states[] = {
+    IDLE_STATE_ACTIVE,
+    IDLE_STATE_IDLE,
+    IDLE_STATE_ACTIVE,
+    IDLE_STATE_ACTIVE,
+    IDLE_STATE_IDLE,
+    IDLE_STATE_IDLE
+  };
+  status_collector_.Simulate(test_states,
+                             sizeof(test_states) / sizeof(IdleState));
+
+  // Process the list a second time with a different collector.
+  // It should be able to count the active periods found by the first
+  // collector, because the results are stored in a pref.
+  TestingDeviceStatusCollector second_collector(&prefs_);
+  second_collector.Simulate(test_states,
+                            sizeof(test_states) / sizeof(IdleState));
+
+  second_collector.GetStatus(&status_);
+  EXPECT_EQ(4, status_.active_time_size());
+  EXPECT_EQ(6 * ActivePeriodMilliseconds(), GetActiveMilliseconds(status_));
+}
+
+TEST_F(DeviceStatusCollectorTest, Times) {
+  IdleState test_states[] = {
+    IDLE_STATE_ACTIVE,
+    IDLE_STATE_IDLE,
+    IDLE_STATE_ACTIVE,
+    IDLE_STATE_ACTIVE,
+    IDLE_STATE_IDLE,
+    IDLE_STATE_IDLE
+  };
+  status_collector_.Simulate(test_states,
+                             sizeof(test_states) / sizeof(IdleState));
+  status_collector_.GetStatus(&status_);
+  EXPECT_EQ(2, status_.active_time_size());
+
+  EXPECT_EQ(3 * ActivePeriodMilliseconds(), GetActiveMilliseconds(status_));
+}
+
+TEST_F(DeviceStatusCollectorTest, MaxStoredPeriods) {
+  IdleState test_states[] = {
+    IDLE_STATE_ACTIVE,
+    IDLE_STATE_IDLE
+  };
+  // Simulate 12 active periods.
+  for (int i = 0; i < 12; i++) {
+    status_collector_.Simulate(test_states,
+                               sizeof(test_states) / sizeof(IdleState));
+  }
+
+  // Check that we don't exceed the max number of periods.
+  status_collector_.GetStatus(&status_);
+  EXPECT_EQ(static_cast<int>(status_collector_.max_stored_active_periods()),
+            status_.active_time_size());
+}
+
+}