Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: chrome/browser/policy/device_management_service_unittest.cc

Issue 8702009: Add device status reports to policy requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <ostream> 5 #include <ostream>
6 #include <vector> 6 #include <vector>
7 7
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "base/string_split.h" 9 #include "base/string_split.h"
10 #include "chrome/browser/policy/device_management_backend_impl.h" 10 #include "chrome/browser/policy/device_management_backend_impl.h"
(...skipping 130 matching lines...) Expand 10 before | Expand all | Expand 10 after
141 fetcher->set_status(GetParam().request_status_); 141 fetcher->set_status(GetParam().request_status_);
142 fetcher->set_response_code(GetParam().http_status_); 142 fetcher->set_response_code(GetParam().http_status_);
143 fetcher->SetResponseString(GetParam().response_); 143 fetcher->SetResponseString(GetParam().response_);
144 fetcher->delegate()->OnURLFetchComplete(fetcher); 144 fetcher->delegate()->OnURLFetchComplete(fetcher);
145 } 145 }
146 146
147 TEST_P(DeviceManagementServiceFailedRequestTest, PolicyRequest) { 147 TEST_P(DeviceManagementServiceFailedRequestTest, PolicyRequest) {
148 DevicePolicyResponseDelegateMock mock; 148 DevicePolicyResponseDelegateMock mock;
149 EXPECT_CALL(mock, OnError(GetParam().expected_error_)); 149 EXPECT_CALL(mock, OnError(GetParam().expected_error_));
150 em::DevicePolicyRequest request; 150 em::DevicePolicyRequest request;
151 em::DeviceStatusReportRequest device_status;
151 request.set_policy_scope(kChromePolicyScope); 152 request.set_policy_scope(kChromePolicyScope);
152 em::DevicePolicySettingRequest* setting_request = 153 em::DevicePolicySettingRequest* setting_request =
153 request.add_setting_request(); 154 request.add_setting_request();
154 setting_request->set_key(kChromeDevicePolicySettingKey); 155 setting_request->set_key(kChromeDevicePolicySettingKey);
155 backend_->ProcessPolicyRequest(kDMToken, kDeviceId, 156 backend_->ProcessPolicyRequest(kDMToken, kDeviceId,
156 CloudPolicyDataStore::USER_AFFILIATION_NONE, 157 CloudPolicyDataStore::USER_AFFILIATION_NONE,
157 request, &mock); 158 request, device_status, &mock);
158 TestURLFetcher* fetcher = factory_.GetFetcherByID(0); 159 TestURLFetcher* fetcher = factory_.GetFetcherByID(0);
159 ASSERT_TRUE(fetcher); 160 ASSERT_TRUE(fetcher);
160 161
161 fetcher->set_url(GURL(kServiceUrl)); 162 fetcher->set_url(GURL(kServiceUrl));
162 fetcher->set_status(GetParam().request_status_); 163 fetcher->set_status(GetParam().request_status_);
163 fetcher->set_response_code(GetParam().http_status_); 164 fetcher->set_response_code(GetParam().http_status_);
164 fetcher->SetResponseString(GetParam().response_); 165 fetcher->SetResponseString(GetParam().response_);
165 fetcher->delegate()->OnURLFetchComplete(fetcher); 166 fetcher->delegate()->OnURLFetchComplete(fetcher);
166 } 167 }
167 168
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 ASSERT_TRUE(fetcher); 418 ASSERT_TRUE(fetcher);
418 419
419 // There shouldn't be any callbacks. 420 // There shouldn't be any callbacks.
420 backend_.reset(); 421 backend_.reset();
421 } 422 }
422 423
423 TEST_F(DeviceManagementServiceTest, CancelPolicyRequest) { 424 TEST_F(DeviceManagementServiceTest, CancelPolicyRequest) {
424 DevicePolicyResponseDelegateMock mock; 425 DevicePolicyResponseDelegateMock mock;
425 EXPECT_CALL(mock, HandlePolicyResponse(_)).Times(0); 426 EXPECT_CALL(mock, HandlePolicyResponse(_)).Times(0);
426 em::DevicePolicyRequest request; 427 em::DevicePolicyRequest request;
428 em::DeviceStatusReportRequest device_status;
427 request.set_policy_scope(kChromePolicyScope); 429 request.set_policy_scope(kChromePolicyScope);
428 em::DevicePolicySettingRequest* setting_request = 430 em::DevicePolicySettingRequest* setting_request =
429 request.add_setting_request(); 431 request.add_setting_request();
430 setting_request->set_key(kChromeDevicePolicySettingKey); 432 setting_request->set_key(kChromeDevicePolicySettingKey);
431 setting_request->set_watermark("stale"); 433 setting_request->set_watermark("stale");
432 backend_->ProcessPolicyRequest(kDMToken, kDeviceId, 434 backend_->ProcessPolicyRequest(kDMToken, kDeviceId,
433 CloudPolicyDataStore::USER_AFFILIATION_NONE, 435 CloudPolicyDataStore::USER_AFFILIATION_NONE,
434 request, &mock); 436 request, device_status, &mock);
435 TestURLFetcher* fetcher = factory_.GetFetcherByID(0); 437 TestURLFetcher* fetcher = factory_.GetFetcherByID(0);
436 ASSERT_TRUE(fetcher); 438 ASSERT_TRUE(fetcher);
437 439
438 // There shouldn't be any callbacks. 440 // There shouldn't be any callbacks.
439 backend_.reset(); 441 backend_.reset();
440 } 442 }
441 443
442 TEST_F(DeviceManagementServiceTest, JobQueueing) { 444 TEST_F(DeviceManagementServiceTest, JobQueueing) {
443 // Start with a non-initialized service. 445 // Start with a non-initialized service.
444 ResetService(); 446 ResetService();
(...skipping 25 matching lines...) Expand all
470 fetcher->set_status(status); 472 fetcher->set_status(status);
471 fetcher->set_response_code(200); 473 fetcher->set_response_code(200);
472 fetcher->SetResponseString(response_data); 474 fetcher->SetResponseString(response_data);
473 fetcher->delegate()->OnURLFetchComplete(fetcher); 475 fetcher->delegate()->OnURLFetchComplete(fetcher);
474 } 476 }
475 477
476 TEST_F(DeviceManagementServiceTest, CancelRequestAfterShutdown) { 478 TEST_F(DeviceManagementServiceTest, CancelRequestAfterShutdown) {
477 DevicePolicyResponseDelegateMock mock; 479 DevicePolicyResponseDelegateMock mock;
478 EXPECT_CALL(mock, HandlePolicyResponse(_)).Times(0); 480 EXPECT_CALL(mock, HandlePolicyResponse(_)).Times(0);
479 em::DevicePolicyRequest request; 481 em::DevicePolicyRequest request;
482 em::DeviceStatusReportRequest device_status;
480 request.set_policy_scope(kChromePolicyScope); 483 request.set_policy_scope(kChromePolicyScope);
481 em::DevicePolicySettingRequest* setting_request = 484 em::DevicePolicySettingRequest* setting_request =
482 request.add_setting_request(); 485 request.add_setting_request();
483 setting_request->set_key(kChromeDevicePolicySettingKey); 486 setting_request->set_key(kChromeDevicePolicySettingKey);
484 setting_request->set_watermark("stale"); 487 setting_request->set_watermark("stale");
485 backend_->ProcessPolicyRequest(kDMToken, kDeviceId, 488 backend_->ProcessPolicyRequest(kDMToken, kDeviceId,
486 CloudPolicyDataStore::USER_AFFILIATION_NONE, 489 CloudPolicyDataStore::USER_AFFILIATION_NONE,
487 request, &mock); 490 request, device_status, &mock);
488 TestURLFetcher* fetcher = factory_.GetFetcherByID(0); 491 TestURLFetcher* fetcher = factory_.GetFetcherByID(0);
489 ASSERT_TRUE(fetcher); 492 ASSERT_TRUE(fetcher);
490 493
491 // Shutdown the service and cancel the job afterwards. 494 // Shutdown the service and cancel the job afterwards.
492 service_->Shutdown(); 495 service_->Shutdown();
493 backend_.reset(); 496 backend_.reset();
494 } 497 }
495 498
496 TEST_F(DeviceManagementServiceTest, CancelDuringCallback) { 499 TEST_F(DeviceManagementServiceTest, CancelDuringCallback) {
497 // Make a request. 500 // Make a request.
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
578 581
579 // Verify that a new URLFetcher was started that bypasses the proxy. 582 // Verify that a new URLFetcher was started that bypasses the proxy.
580 fetcher = factory_.GetFetcherByID(0); 583 fetcher = factory_.GetFetcherByID(0);
581 ASSERT_TRUE(fetcher); 584 ASSERT_TRUE(fetcher);
582 EXPECT_TRUE((fetcher->GetLoadFlags() & net::LOAD_BYPASS_PROXY) != 0); 585 EXPECT_TRUE((fetcher->GetLoadFlags() & net::LOAD_BYPASS_PROXY) != 0);
583 EXPECT_EQ(original_url, fetcher->GetOriginalURL()); 586 EXPECT_EQ(original_url, fetcher->GetOriginalURL());
584 EXPECT_EQ(upload_data, fetcher->upload_data()); 587 EXPECT_EQ(upload_data, fetcher->upload_data());
585 } 588 }
586 589
587 } // namespace policy 590 } // namespace policy
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698