Strip invalid characters (line breaks, tabs), javascript:schemes from the copied text while pasti...

chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdio.h>
 
 #include "base/message_loop.h"
 #include "base/string16.h"
 #include "base/string_util.h"
 #include "base/time.h"
@@ skipping 739 matching lines @@
     ASSERT_FALSE(omnibox_view->model()->is_keyword_hint());
     ASSERT_EQ(text, omnibox_view->model()->keyword());
     ASSERT_TRUE(omnibox_view->GetText().empty());
 
     // Revert to keyword hint mode.
     omnibox_view->model()->ClearKeyword(string16());
     ASSERT_TRUE(omnibox_view->model()->is_keyword_hint());
     ASSERT_EQ(text, omnibox_view->model()->keyword());
     ASSERT_EQ(text, omnibox_view->GetText());
 
     // Keyword shouldn't be accepted by pasting.

[Peter Kasting, 2011/11/29 19:07:28]

This block should be removed (since no platforms support pasting a space) and
instead just the SetWindowTextAndCaretPos() call should be moved down to the
beginning of the next block.

[SanjoyPal, 2011/11/30 06:49:26]

Done.

     // Simulate pasting a whitespace to the end of content.
     omnibox_view->OnBeforePossibleChange();
     omnibox_view->model()->on_paste();
     omnibox_view->SetWindowTextAndCaretPos(
         text + char16(' '), text.length() + 1);
     omnibox_view->OnAfterPossibleChange();
     // Should be still in keyword hint mode.
     ASSERT_TRUE(omnibox_view->model()->is_keyword_hint());
     ASSERT_EQ(text, omnibox_view->model()->keyword());
     ASSERT_EQ(text + char16(' '), omnibox_view->GetText());
@@ skipping 606 matching lines @@
 }
 
 IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest, EscapeToDefaultMatch) {
   EscapeToDefaultMatchTest();
 }
 
 IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest, BasicTextOperations) {
   BasicTextOperationsTest();
 }
 
+// This test is DISABLED because of the behavioral modifications of omnibox.

[Peter Kasting, 2011/11/29 19:07:28]

It's wrong to disable the test.  If the test isn't passing it needs to be fixed,
not disabled.  The test obviously passes on Windows and Mac already so there's
no obvious reason it shouldn't work on Windows.

[SanjoyPal, 2011/11/30 06:49:26]

Done.

+// Please refer http://crbug.com/82181.
+#if defined(OS_LINUX)
+IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest, DISABLED_AcceptKeywordBySpace) {
+#else
 IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest, AcceptKeywordBySpace) {
+#endif  // OS_LINUX
   AcceptKeywordBySpaceTest();
 }
 
 IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest,
                        NonSubstitutingKeywordTest) {
   NonSubstitutingKeywordTest();
 }
 
 IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest, DeleteItem) {
   DeleteItemTest();
@@ skipping 10 matching lines @@
                        PersistKeywordModeOnTabSwitch) {
   PersistKeywordModeOnTabSwitch();
 }
 
 IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest,
                        CtrlKeyPressedWithInlineAutocompleteTest) {
   CtrlKeyPressedWithInlineAutocompleteTest();
 }
 
 #endif