Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 87012: plugins: move NativeLibrary into base. (Closed)

Created:
11 years, 8 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

plugins: move NativeLibrary into base. NativeLibrary is used by some plugin code under chrome/. Rather than including webkit/glue there, this relocation is the smallest logical bite to take. :\

Patch Set 1 #

Patch Set 2 : windows fix (still running through tryserver) #

Patch Set 3 : more fixes from trybot #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -132 lines) Patch
M base/base.gyp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A base/native_library.h View 1 chunk +47 lines, -0 lines 1 comment Download
A base/native_library_linux.cc View 1 chunk +36 lines, -0 lines 1 comment Download
A base/native_library_mac.mm View 1 chunk +38 lines, -0 lines 0 comments Download
A base/native_library_win.cc View 1 1 chunk +46 lines, -0 lines 0 comments Download
M chrome/plugin/plugin_thread.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/plugin/plugin_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/plugins/plugin_lib.h View 2 chunks +2 lines, -30 lines 0 comments Download
M webkit/glue/plugins/plugin_lib.cc View 6 chunks +22 lines, -13 lines 0 comments Download
M webkit/glue/plugins/plugin_lib_linux.cc View 1 chunk +1 line, -25 lines 0 comments Download
M webkit/glue/plugins/plugin_lib_mac.mm View 2 chunks +1 line, -27 lines 0 comments Download
M webkit/glue/plugins/plugin_lib_win.cc View 1 chunk +0 lines, -35 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Evan Martin
jam: review, rest FYI This is in response to a review comment of yours on ...
11 years, 8 months ago (2009-04-20 23:20:45 UTC) #1
jam
11 years, 8 months ago (2009-04-21 00:26:53 UTC) #2
lgtm, thanks for doing this

http://codereview.chromium.org/87012/diff/25/1014
File base/native_library.h (right):

http://codereview.chromium.org/87012/diff/25/1014#newcode9
Line 9: // a loadable module.  It's used for holding plugin handles.
no need to mention plugins here

http://codereview.chromium.org/87012/diff/25/1015
File base/native_library_linux.cc (right):

http://codereview.chromium.org/87012/diff/25/1015#newcode14
Line 14: // static
nit: i know some places of the code do it often, but I still think it's
redundant to put "// static" infront of methods.  why not "// private" or "//
public"?!

Powered by Google App Engine
This is Rietveld 408576698