Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 8701006: Clean up JavaScript files to better follow coding standard. (Closed)

Created:
9 years ago by Lasse Reichstein
Modified:
9 years ago
Reviewers:
Yang, rossberg
CC:
v8-dev
Visibility:
Public.

Description

Clean up JavaScript files to better follow coding standard. Multiline conditionals must use braces. Semicolons are not optional. Committed: http://code.google.com/p/v8/source/detail?r=10074

Patch Set 1 #

Total comments: 1

Patch Set 2 : More lint fixes - long lines and missing semicolons. #

Patch Set 3 : More long lines fixed. #

Patch Set 4 : Remove empty statements. #

Patch Set 5 : Remove more empty statments and fix bug. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -368 lines) Patch
M src/array.js View 1 2 3 4 chunks +10 lines, -7 lines 0 comments Download
M src/d8.js View 1 2 3 44 chunks +56 lines, -53 lines 0 comments Download
M src/date.js View 1 2 9 chunks +23 lines, -12 lines 0 comments Download
M src/debug-debugger.js View 1 2 3 4 48 chunks +81 lines, -66 lines 0 comments Download
M src/json.js View 1 chunk +1 line, -1 line 0 comments Download
M src/liveedit-debugger.js View 1 11 chunks +24 lines, -23 lines 0 comments Download
M src/messages.js View 1 2 3 4 24 chunks +56 lines, -41 lines 0 comments Download
M src/mirror-debugger.js View 1 2 3 68 chunks +106 lines, -103 lines 0 comments Download
M src/regexp.js View 1 2 3 2 chunks +37 lines, -20 lines 0 comments Download
M src/runtime.js View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/string.js View 1 2 3 9 chunks +24 lines, -15 lines 0 comments Download
M src/uri.js View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M src/v8natives.js View 1 2 16 chunks +35 lines, -20 lines 0 comments Download
M test/mjsunit/bugs/bug-618.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein
PTAL
9 years ago (2011-11-25 15:34:40 UTC) #1
Yang
On 2011/11/25 15:34:40, Lasse Reichstein wrote: > PTAL drive-by LGTM with comments. Did not make ...
9 years ago (2011-11-25 15:55:04 UTC) #2
Yang
actually sending the comment... http://codereview.chromium.org/8701006/diff/1/src/v8natives.js File src/v8natives.js (right): http://codereview.chromium.org/8701006/diff/1/src/v8natives.js#newcode891 src/v8natives.js:891: throw MakeTypeError("obj_ctor_property_non_object", ["getOwnPropertyNames"]); Might as ...
9 years ago (2011-11-25 15:56:01 UTC) #3
Lasse Reichstein
Good idea. Also checked for long lines and superflous semicolons. Yang, could you do the ...
9 years ago (2011-11-28 10:54:42 UTC) #4
Yang
9 years ago (2011-11-28 11:58:39 UTC) #5
On 2011/11/28 10:54:42, Lasse Reichstein wrote:
> Good idea. Also checked for long lines and superflous semicolons.
> Yang, could you do the review, since Rossberg is temporarily incapacitated?

LGTM.

Powered by Google App Engine
This is Rietveld 408576698