Issue 8701002: Value::GetAsDictionary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8701002: Value::GetAsDictionary (Closed)

Created:
9 years ago by battre

Modified:
9 years ago

Reviewers:
Nico

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org, Bernhard Bauer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -1 line)			Patch
M	base/values.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	base/values.cc	View		2 chunks	+20 lines, -0 lines	0 comments	Download
M	base/values_unittest.cc	View		3 chunks	+17 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

battre

Hi Nico, we have Value::GetAsList but no Value::GetAsDictionary. This is a CL to fix the ...

9 years ago (2011-11-25 10:09:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/8701002/5

9 years ago (2011-11-25 20:26:39 UTC) #3

commit-bot: I haz the power

Try job failure for 8701002-5 (retry) on linux_rel for steps "browser_tests, ui_tests, interactive_ui_tests". It's a ...

9 years ago (2011-11-25 22:00:02 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/battre@chromium.org/8701002/5

9 years ago (2011-11-25 23:11:27 UTC) #5

Change committed as 111623