Issue 8700014: Utility to draw GAIA pictures

Issue 8700014: Utility to draw GAIA pictures (Closed)

Created:
9 years ago by sail

Modified:
9 years ago

Reviewers:
Robert Sesek, Miranda Callahan

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Utility to draw GAIA pictures This CL adds common utility functions to draw GAIA pictures in the avatar menu bubble and in the title bar. BUG=91241 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112159

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix unit test #

Patch Set 4 : rebase #

Total comments: 6

Patch Set 5 : address review comments #

Patch Set 6 : address review comments #

Patch Set 7 : rebase #

Patch Set 8 : merge #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+163 lines, -7 lines)			Patch
M	chrome/browser/profiles/avatar_menu_model.h	View	1 2 3 4 5	2 chunks	+2 lines, -5 lines	0 comments	Download
M	chrome/browser/profiles/avatar_menu_model.cc	View	1 2 3 4 5 6 7	3 chunks	+8 lines, -2 lines	0 comments	Download
A	chrome/browser/profiles/profile_info_util.h	View	1 2 3 4 5	1 chunk	+29 lines, -0 lines	0 comments	Download
A	chrome/browser/profiles/profile_info_util.cc	View		1 chunk	+74 lines, -0 lines	0 comments	Download
A	chrome/browser/profiles/profile_info_util_unittest.cc	View	1 2 3 4 5 6 7	1 chunk	+47 lines, -0 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4 5 6 7	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4 5 6 7	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sail

These utilities are used in the following CLs: http://codereview.chromium.org/8671002/ http://codereview.chromium.org/8708001 http://codereview.chromium.org/8709001

9 years ago (2011-11-26 06:49:09 UTC) #1

Miranda Callahan

LGTM. http://codereview.chromium.org/8700014/diff/8001/chrome/browser/profiles/avatar_menu_model.h File chrome/browser/profiles/avatar_menu_model.h (right): http://codereview.chromium.org/8700014/diff/8001/chrome/browser/profiles/avatar_menu_model.h#newcode22 chrome/browser/profiles/avatar_menu_model.h:22: class Image; you can remove the forward-decl.

9 years ago (2011-11-28 14:56:47 UTC) #2

sail

http://codereview.chromium.org/8700014/diff/8001/chrome/browser/profiles/avatar_menu_model.h File chrome/browser/profiles/avatar_menu_model.h (right): http://codereview.chromium.org/8700014/diff/8001/chrome/browser/profiles/avatar_menu_model.h#newcode22 chrome/browser/profiles/avatar_menu_model.h:22: class Image; On 2011/11/28 14:56:48, Miranda Callahan wrote: > ...

9 years ago (2011-11-28 15:25:16 UTC) #3

Robert Sesek

lgtm http://codereview.chromium.org/8700014/diff/8001/chrome/browser/profiles/avatar_menu_model.h File chrome/browser/profiles/avatar_menu_model.h (right): http://codereview.chromium.org/8700014/diff/8001/chrome/browser/profiles/avatar_menu_model.h#newcode37 chrome/browser/profiles/avatar_menu_model.h:37: const gfx::Image icon; Should this still be const? ...

9 years ago (2011-11-28 15:30:15 UTC) #4

sail

9 years ago (2011-11-28 15:39:39 UTC) #5

http://codereview.chromium.org/8700014/diff/8001/chrome/browser/profiles/avat...
File chrome/browser/profiles/avatar_menu_model.h (right):

http://codereview.chromium.org/8700014/diff/8001/chrome/browser/profiles/avat...
chrome/browser/profiles/avatar_menu_model.h:37: const gfx::Image icon;
On 2011/11/28 15:30:15, rsesek wrote:
> Should this still be const? gfx::Image is effectively so.

Done.

http://codereview.chromium.org/8700014/diff/8001/chrome/browser/profiles/prof...
File chrome/browser/profiles/profile_info_util.h (right):

http://codereview.chromium.org/8700014/diff/8001/chrome/browser/profiles/prof...
chrome/browser/profiles/profile_info_util.h:16: gfx::Image
GetAvatarIconForMenu(const gfx::Image& image,
On 2011/11/28 15:30:15, rsesek wrote:
> These both should have comments.

Done.

Expand Messages | Collapse Messages