ui/aura/window.cc - Issue 8700013: Release aura::Desktop event handler windows on detaching an ancestor window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/aura/window.cc

Issue 8700013: Release aura::Desktop event handler windows on detaching an ancestor window. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use parent_ to access parent. Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/aura/window.cc

diff --git a/ui/aura/window.cc b/ui/aura/window.cc

index 6b4c5d2553823dc126021633a0cf45583728585e..d394d106f6e79719fc8d1438c04739547129b439 100644

--- a/ui/aura/window.cc

+++ b/ui/aura/window.cc

@@ -277,6 +277,14 @@ void Window::RemoveChild(Window* child) {

child->OnParentChanged();

}

+bool Window::Contains(const Window* other) const {

+ for (const Window* parent = other; parent; parent = parent->parent_) {

+ if (parent == this)

+ return true;

+ }

+ return false;

Window* Window::GetChildById(int id) {

return const_cast<Window*>(const_cast<const Window*>(this)->GetChildById(id));

}

« no previous file with comments | « ui/aura/window.h ('k') | ui/aura/window_unittest.cc » ('j') | no next file with comments »