src/ic.cc - Issue 8700008: New approach to Crankshaft decision-making

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic.cc

Issue 8700008: New approach to Crankshaft decision-making (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fix function self-optimization; address first comment Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic.cc

diff --git a/src/ic.cc b/src/ic.cc

index d816e7765ed77c9a14f782f8f3a95de0ad5906db..c8c1eed3bc53d39e7746acd4b26fd7ba5a367634 100644

--- a/src/ic.cc

+++ b/src/ic.cc

@@ -1672,6 +1672,9 @@ MaybeObject* KeyedStoreIC::Store(State state,

if (receiver->elements()->map() ==

isolate()->heap()->non_strict_arguments_elements_map()) {

stub = non_strict_arguments_stub();

+ } else if (receiver->elements()->map() ==

+ isolate()->heap()->fixed_cow_array_map()) {

+ // Do nothing, just keep the generic stub.

} else if (!force_generic) {

if (key->IsSmi() && (target() != *non_strict_arguments_stub())) {

StubKind stub_kind = STORE_NO_TRANSITION;