Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1341)

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 8700008: New approach to Crankshaft decision-making (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix snapshot build and memory leaks Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ic.cc » ('j') | src/platform-linux.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/full-codegen-ia32.cc
diff --git a/src/ia32/full-codegen-ia32.cc b/src/ia32/full-codegen-ia32.cc
index 6e2391110b2346903d53b6d365fbe3d405afe3c1..7718714e88789038a2c2ae7212a87b3d00921780 100644
--- a/src/ia32/full-codegen-ia32.cc
+++ b/src/ia32/full-codegen-ia32.cc
@@ -129,6 +129,23 @@ void FullCodeGenerator::Generate(CompilationInfo* info) {
}
#endif
+ // Primitive functions are unlikely to be picked up by the stack-walking
+ // profiler, so they trigger their own optimization when they're called
+ // for the SharedFunctionInfo::kCallsUntilPrimitiveOptimization-th time.
+ if (FLAG_crankshaft &&
+ !info->shared_info().is_null() &&
+ info->function()->is_primitive()) {
+ info->shared_info()->set_call_counter(
+ SharedFunctionInfo::kCallsUntilPrimitiveOptimization);
+ __ mov(eax, Immediate(info->shared_info()));
+ // eax: shared function info
+ __ sub(FieldOperand(eax, SharedFunctionInfo::kCallCounterOffset),
+ Immediate(Smi::FromInt(1)));
+ Handle<Code> compile_stub(
+ isolate()->builtins()->builtin(Builtins::kLazyRecompile));
+ __ j(zero, compile_stub);
+ }
+
// Strict mode functions and builtins need to replace the receiver
// with undefined when called as functions (without an explicit
// receiver object). ecx is zero for method calls and non-zero for
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ic.cc » ('j') | src/platform-linux.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698