Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/x64/full-codegen-x64.cc

Issue 8700008: New approach to Crankshaft decision-making (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix function self-optimization; address first comment Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« src/runtime-profiler.cc ('K') | « src/x64/code-stubs-x64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
122 SetFunctionPosition(function()); 122 SetFunctionPosition(function());
123 Comment cmnt(masm_, "[ function compiled by full code generator"); 123 Comment cmnt(masm_, "[ function compiled by full code generator");
124 124
125 #ifdef DEBUG 125 #ifdef DEBUG
126 if (strlen(FLAG_stop_at) > 0 && 126 if (strlen(FLAG_stop_at) > 0 &&
127 info->function()->name()->IsEqualTo(CStrVector(FLAG_stop_at))) { 127 info->function()->name()->IsEqualTo(CStrVector(FLAG_stop_at))) {
128 __ int3(); 128 __ int3();
129 } 129 }
130 #endif 130 #endif
131 131
132 // Primitive functions are unlikely to be picked up by the stack-walking
133 // profiler, so they trigger their own optimization when they're called
134 // for the SharedFunctionInfo::kCallsUntilPrimitiveOptimization-th time.
135 if (FLAG_crankshaft &&
136 info->function()->is_primitive() &&
137 !Serializer::enabled()) {
138 if (FLAG_trace_opt) {
139 PrintF("[adding self-optimization header to %s]\n",
140 *info->function()->debug_name()->ToCString());
141 }
142 MaybeObject* maybe_cell = isolate()->heap()->AllocateJSGlobalPropertyCell(
143 Smi::FromInt(Compiler::kCallsUntilPrimitiveOpt));
144 JSGlobalPropertyCell* cell;
145 if (maybe_cell->To(&cell)) {
146 __ movq(rax, Handle<JSGlobalPropertyCell>(cell),
147 RelocInfo::EMBEDDED_OBJECT);
148 __ SmiAddConstant(FieldOperand(rax, JSGlobalPropertyCell::kValueOffset),
149 Smi::FromInt(-1));
150 Handle<Code> compile_stub(
151 isolate()->builtins()->builtin(Builtins::kLazyRecompile));
152 __ j(zero, compile_stub, RelocInfo::CODE_TARGET);
153 }
154 }
155
132 // Strict mode functions and builtins need to replace the receiver 156 // Strict mode functions and builtins need to replace the receiver
133 // with undefined when called as functions (without an explicit 157 // with undefined when called as functions (without an explicit
134 // receiver object). rcx is zero for method calls and non-zero for 158 // receiver object). rcx is zero for method calls and non-zero for
135 // function calls. 159 // function calls.
136 if (!info->is_classic_mode() || info->is_native()) { 160 if (!info->is_classic_mode() || info->is_native()) {
137 Label ok; 161 Label ok;
138 __ testq(rcx, rcx); 162 __ testq(rcx, rcx);
139 __ j(zero, &ok, Label::kNear); 163 __ j(zero, &ok, Label::kNear);
140 // +1 for return address. 164 // +1 for return address.
141 int receiver_offset = (info->scope()->num_parameters() + 1) * kPointerSize; 165 int receiver_offset = (info->scope()->num_parameters() + 1) * kPointerSize;
(...skipping 4204 matching lines...) Expand 10 before | Expand all | Expand 10 after
4346 *context_length = 0; 4370 *context_length = 0;
4347 return previous_; 4371 return previous_;
4348 } 4372 }
4349 4373
4350 4374
4351 #undef __ 4375 #undef __
4352 4376
4353 } } // namespace v8::internal 4377 } } // namespace v8::internal
4354 4378
4355 #endif // V8_TARGET_ARCH_X64 4379 #endif // V8_TARGET_ARCH_X64
OLDNEW
« src/runtime-profiler.cc ('K') | « src/x64/code-stubs-x64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698