New approach to Crankshaft decision-making

src/objects.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 5443 matching lines @@
   // before.
   Object* SetInstanceClassName(String* name);
 
   // Returns if this function has been compiled to native code yet.
   inline bool is_compiled();
 
   // [next_function_link]: Field for linking functions. This list is treated as
   // a weak list by the GC.
   DECL_ACCESSORS(next_function_link, Object)
 
+  inline int profiler_ticks();

[fschneider, 2011/12/12 11:31:21]

Shouldn't be this on SharedFunctionInfo instead?

[fschneider, 2011/12/13 11:53:01]

This increases the size of each JSFunction by 1 word  from 36 to 40 (11%). This
could hurt memory-constrained devices on programs with lots of closures. I'd
prefer a solution without additional space cost.

[Jakob Kummerow, 2011/12/14 08:42:31]

Done.

+  inline void set_profiler_ticks(int ticks);
+
   // Prints the name of the function using PrintF.
   inline void PrintName() {
     PrintName(stdout);
   }
   void PrintName(FILE* out);
 
   // Casting.
   static inline JSFunction* cast(Object* obj);
 
   // Iterates the objects, including code objects indirectly referenced
@@ skipping 19 matching lines @@
 
   // Layout descriptors. The last property (from kNonWeakFieldsEndOffset to
   // kSize) is weak and has special handling during garbage collection.
   static const int kCodeEntryOffset = JSObject::kHeaderSize;
   static const int kPrototypeOrInitialMapOffset =
       kCodeEntryOffset + kPointerSize;
   static const int kSharedFunctionInfoOffset =
       kPrototypeOrInitialMapOffset + kPointerSize;
   static const int kContextOffset = kSharedFunctionInfoOffset + kPointerSize;
   static const int kLiteralsOffset = kContextOffset + kPointerSize;
-  static const int kNonWeakFieldsEndOffset = kLiteralsOffset + kPointerSize;
+  static const int kProfilerTicksOffset = kLiteralsOffset + kPointerSize;
+  static const int kNonWeakFieldsEndOffset =
+      kProfilerTicksOffset + kPointerSize;
   static const int kNextFunctionLinkOffset = kNonWeakFieldsEndOffset;
   static const int kSize = kNextFunctionLinkOffset + kPointerSize;
 
   // Layout of the literals array.
   static const int kLiteralsPrefixSize = 1;
   static const int kLiteralGlobalContextIndex = 0;
 
   // Layout of the bound-function binding array.
   static const int kBoundFunctionIndex = 0;
   static const int kBoundThisIndex = 1;
@@ skipping 2469 matching lines @@
     } else {
       value &= ~(1 << bit_position);
     }
     return value;
   }
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_OBJECTS_H_