New approach to Crankshaft decision-making

src/ia32/full-codegen-ia32.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 111 matching lines @@
   SetFunctionPosition(function());
   Comment cmnt(masm_, "[ function compiled by full code generator");
 
 #ifdef DEBUG
   if (strlen(FLAG_stop_at) > 0 &&
       info->function()->name()->IsEqualTo(CStrVector(FLAG_stop_at))) {
     __ int3();
   }
 #endif
 
+  // Primitive functions are unlikely to be picked up by the stack-walking
+  // profiler, so they trigger their own optimization when they're called
+  // for the SharedFunctionInfo::kCallsUntilPrimitiveOptimization-th time.
+  if (FLAG_crankshaft &&

[fschneider, 2011/12/13 11:53:01]

If a function has optimization disabled via DisableOptimization() because we
can't optimize it or we deoptimized frequently, we should not add code for
counting.

[Jakob Kummerow, 2011/12/14 08:42:31]

Done.

+      info->function()->is_primitive() &&

[fschneider, 2011/12/12 11:31:21]

What is a primitive function? I can't find the source code for this predicate.

[Jakob Kummerow, 2011/12/14 08:42:31]

Basically a function that doesn't contain loops, calls, or un-inline-able
statements. The definition is in http://codereview.chromium.org/8677008/

+      !Serializer::enabled()) {
+    if (FLAG_trace_opt) {
+      PrintF("[adding self-optimization header to %s]\n",
+             *info->function()->debug_name()->ToCString());
+    }
+    MaybeObject* maybe_cell = isolate()->heap()->AllocateJSGlobalPropertyCell(
+        Smi::FromInt(Compiler::kCallsUntilPrimitiveOpt));
+    JSGlobalPropertyCell* cell;
+    if (maybe_cell->To(&cell)) {
+      __ mov(eax, Immediate(Handle<JSGlobalPropertyCell>(cell)));
+      __ sub(FieldOperand(eax, JSGlobalPropertyCell::kValueOffset),
+             Immediate(Smi::FromInt(1)));
+      Handle<Code> compile_stub(
+          isolate()->builtins()->builtin(Builtins::kLazyRecompile));
+      __ j(zero, compile_stub);
+    }
+  }
+
   // Strict mode functions and builtins need to replace the receiver
   // with undefined when called as functions (without an explicit
   // receiver object). ecx is zero for method calls and non-zero for
   // function calls.
   if (!info->is_classic_mode() || info->is_native()) {
     Label ok;
     __ test(ecx, ecx);
     __ j(zero, &ok, Label::kNear);
     // +1 for return address.
     int receiver_offset = (info->scope()->num_parameters() + 1) * kPointerSize;
@@ skipping 4238 matching lines @@
   *context_length = 0;
   return previous_;
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_IA32