Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: src/arm/full-codegen-arm.cc

Issue 8700008: New approach to Crankshaft decision-making (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fix function self-optimization; address first comment Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 SetFunctionPosition(function()); 132 SetFunctionPosition(function());
133 Comment cmnt(masm_, "[ function compiled by full code generator"); 133 Comment cmnt(masm_, "[ function compiled by full code generator");
134 134
135 #ifdef DEBUG 135 #ifdef DEBUG
136 if (strlen(FLAG_stop_at) > 0 && 136 if (strlen(FLAG_stop_at) > 0 &&
137 info->function()->name()->IsEqualTo(CStrVector(FLAG_stop_at))) { 137 info->function()->name()->IsEqualTo(CStrVector(FLAG_stop_at))) {
138 __ stop("stop-at"); 138 __ stop("stop-at");
139 } 139 }
140 #endif 140 #endif
141 141
142 // Primitive functions are unlikely to be picked up by the stack-walking
143 // profiler, so they trigger their own optimization when they're called
144 // for the SharedFunctionInfo::kCallsUntilPrimitiveOptimization-th time.
145 if (info->function()->is_primitive() &&
146 FLAG_crankshaft &&
147 !Serializer::enabled()) {
148 if (FLAG_trace_opt) {
149 PrintF("[adding self-optimization header to %s]\n",
150 *info->function()->debug_name()->ToCString());
151 }
152 MaybeObject* maybe_cell = isolate()->heap()->AllocateJSGlobalPropertyCell(
153 Smi::FromInt(Compiler::kCallsUntilPrimitiveOpt));
154 JSGlobalPropertyCell* cell;
155 if (maybe_cell->To(&cell)) {
156 __ mov(r2, Operand(Handle<JSGlobalPropertyCell>(cell)));
157 __ ldr(r3, FieldMemOperand(r2, JSGlobalPropertyCell::kValueOffset));
158 __ sub(r3, r3, Operand(Smi::FromInt(1)), SetCC);
159 __ str(r3, FieldMemOperand(r2, JSGlobalPropertyCell::kValueOffset));
160 Handle<Code> compile_stub(
161 isolate()->builtins()->builtin(Builtins::kLazyRecompile));
162 __ Jump(compile_stub, RelocInfo::CODE_TARGET, eq);
163 }
164 }
165
142 // Strict mode functions and builtins need to replace the receiver 166 // Strict mode functions and builtins need to replace the receiver
143 // with undefined when called as functions (without an explicit 167 // with undefined when called as functions (without an explicit
144 // receiver object). r5 is zero for method calls and non-zero for 168 // receiver object). r5 is zero for method calls and non-zero for
145 // function calls. 169 // function calls.
146 if (!info->is_classic_mode() || info->is_native()) { 170 if (!info->is_classic_mode() || info->is_native()) {
147 Label ok; 171 Label ok;
148 __ cmp(r5, Operand(0)); 172 __ cmp(r5, Operand(0));
149 __ b(eq, &ok); 173 __ b(eq, &ok);
150 int receiver_offset = info->scope()->num_parameters() * kPointerSize; 174 int receiver_offset = info->scope()->num_parameters() * kPointerSize;
151 __ LoadRoot(r2, Heap::kUndefinedValueRootIndex); 175 __ LoadRoot(r2, Heap::kUndefinedValueRootIndex);
(...skipping 4234 matching lines...) Expand 10 before | Expand all | Expand 10 after
4386 *context_length = 0; 4410 *context_length = 0;
4387 return previous_; 4411 return previous_;
4388 } 4412 }
4389 4413
4390 4414
4391 #undef __ 4415 #undef __
4392 4416
4393 } } // namespace v8::internal 4417 } } // namespace v8::internal
4394 4418
4395 #endif // V8_TARGET_ARCH_ARM 4419 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/compiler.h » ('j') | src/ia32/full-codegen-ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698