Issue 8700004: Implement Math.tan in generated code.

Issue 8700004: Implement Math.tan in generated code. (Closed)

Created:
9 years ago by Yang

Modified:
9 years ago

Reviewers:
Lasse Reichstein, ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Implement Math.tan in generated code. Committed: http://code.google.com/p/v8/source/detail?r=10067

Patch Set 1 #

Total comments: 2

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+150 lines, -3 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	4 chunks	+8 lines, -0 lines	0 comments	Download
M	src/arm/full-codegen-arm.cc	View	1 chunk	+12 lines, -0 lines	1 comment	Download
M	src/arm/lithium-codegen-arm.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/assembler.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/assembler.cc	View	2 chunks	+13 lines, -0 lines	0 comments	Download
M	src/hydrogen.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/assembler-ia32.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	5 chunks	+13 lines, -1 line	0 comments	Download
M	src/ia32/full-codegen-ia32.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	src/math.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/runtime.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/assembler-x64.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/assembler-x64.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	5 chunks	+13 lines, -1 line	1 comment	Download
M	src/x64/full-codegen-x64.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

This takes advantage of FPTAN on intel architectures. Please take a look.

9 years ago (2011-11-25 12:10:29 UTC) #1

Lasse Reichstein

drive-by comment. http://codereview.chromium.org/8700004/diff/1/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/8700004/diff/1/src/x64/code-stubs-x64.cc#newcode1781 src/x64/code-stubs-x64.cc:1781: __ fincstp(); If you just want to ...

9 years ago (2011-11-25 12:46:56 UTC) #2

ulan

9 years ago (2011-11-25 13:11:41 UTC) #3

LGTM if Lasse's comment is addressed.

http://codereview.chromium.org/8700004/diff/1/src/arm/full-codegen-arm.cc
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/8700004/diff/1/src/arm/full-codegen-arm.cc#new...
src/arm/full-codegen-arm.cc:3142: context()->Plug(r0);
In future maybe we could define a platform-specific function
context()->PlugResultRegister() and then move all the other code to
platform-independent code?

Expand Messages | Collapse Messages