Pulling in nacl glibc toolchain.

Pulling in nacl glibc toolchain.
Pulling in pymox.

BUG=None
TEST=None
R=noelallen@google.com

TBR
Committed: http://code.google.com/p/nativeclient-sdk/source/detail?r=111626

[Lei Zhang, 2011-11-26 08:27:36]

http://codereview.chromium.org/8699012/diff/1/DEPS
File DEPS (right):

http://codereview.chromium.org/8699012/diff/1/DEPS#newcode115
DEPS:115: "src/third_party/pymox":
You should have pulled this into src/third_party/pymox/src to leave room to add
the README.chromium file to meet the requirements outlined in
http://www.chromium.org/developers/adding-3rd-party-libraries

http://codereview.chromium.org/8699012/diff/1/DEPS#newcode116
DEPS:116: "http://pymox.googlecode.com/svn/trunk@61",
nit: you can use (Var("googlecode_url") % "pymox") here.

http://codereview.chromium.org/8699012/diff/1/DEPS#newcode116
DEPS:116: "http://pymox.googlecode.com/svn/trunk@61",
BTW, why r61 and not r66?

[bradn, 2011-11-28 18:22:39]

On Sat, Nov 26, 2011 at 12:27 AM, <thestig@chromium.org> wrote:

>
>
http://codereview.chromium.**org/8699012/diff/1/DEPS<http://codereview.chromi...
> File DEPS (right):
>
>
http://codereview.chromium.**org/8699012/diff/1/DEPS#**newcode115<http://code...
> DEPS:115: "src/third_party/pymox":
> You should have pulled this into src/third_party/pymox/src to leave room
> to add the README.chromium file to meet the requirements outlined in
>
http://www.chromium.org/**developers/adding-3rd-party-**libraries<http://www....
>
> Ah, good point.


>
http://codereview.chromium.**org/8699012/diff/1/DEPS#**newcode116<http://code...
> DEPS:116:
"http://pymox.googlecode.com/**svn/trunk@61<http://pymox.googlecode.com/svn/trunk@61>
> ",
> nit: you can use (Var("googlecode_url") % "pymox") here.
>
> Well yes and no, that variable get overridden in the golo to assume we
have mirrors of everything on googlecode, which we don't have for this one.
But I'll likely get that setup today.



>
http://codereview.chromium.**org/8699012/diff/1/DEPS#**newcode116<http://code...
> DEPS:116:
"http://pymox.googlecode.com/**svn/trunk@61<http://pymox.googlecode.com/svn/trunk@61>
> ",
> BTW, why r61 and not r66?
>
>
Sorry, we got a mandate to migrate where a bunch of stuff lives.
I was largely trying to bring over stuf with minimum change.
I'll give the new version a try (as I'll need to in order to get the header
change).




>
http://codereview.chromium.**org/8699012/<http://codereview.chromium.org/8699...
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To post to this group, send email to native-client-reviews@googlegroups.com.
To unsubscribe from this group, send email to
native-client-reviews+unsubscribe@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/native-client-reviews?hl=en.