Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 8699011: Use callback_forward.h instead of callback.h where possible. (Closed)

Created:
9 years ago by erikwright (departed)
Modified:
9 years ago
Reviewers:
Rick Campbell
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing), brettw-cc_chromium.org
Visibility:
Public.

Description

Use callback_forward.h instead of callback.h where possible. You are asked to review this as you have OWNERS for these files. BUG=None TEST=Compiles R=tim@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112497

Patch Set 1 #

Patch Set 2 : Remove callback_forward.h, which was committed as part of a separate CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/browser/sync/glue/browser_thread_model_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/history_model_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/password_model_worker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/internal_api/sync_manager.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
erikwright (departed)
See this chromium-dev thread for the rationale behind the change: http://goo.gl/I3kob callback_forward.h will be committed ...
9 years ago (2011-11-26 02:38:36 UTC) #1
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years ago (2011-11-29 17:06:12 UTC) #2
Rick Campbell
lgtm
9 years ago (2011-11-30 19:44:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/8699011/3001
9 years ago (2011-11-30 19:57:51 UTC) #4
commit-bot: I haz the power
Try job failure for 8699011-3001 (retry) on win_rel for step "compile" (clobber build). It's a ...
9 years ago (2011-11-30 21:15:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/8699011/3001
9 years ago (2011-12-01 17:26:04 UTC) #6
commit-bot: I haz the power
9 years ago (2011-12-01 19:54:50 UTC) #7
Change committed as 112497

Powered by Google App Engine
This is Rietveld 408576698