Issue 8699008: Use callback_forward.h instead of callback.h where possible.

Issue 8699008: Use callback_forward.h instead of callback.h where possible. (Closed)

Created:
9 years ago by erikwright (departed)

Modified:
9 years ago

Reviewers:
awong, Ben Goodger (Google)

CC:
chromium-reviews, hclam+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, amit, acolwell+watch_chromium.org, annacc+watch_chromium.org, robertshield, brettw-cc_chromium.org, vrk (LEFT CHROMIUM), darin-cc_chromium.org, scherkus (not reviewing), ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Use callback_forward.h instead of callback.h where possible. callback_forward.h will be committed separately, before this commit, and is included here only to assist in running try jobs. It will be removed before the final commit. You are asked to review this as you have OWNERS for these files. BUG=None TEST=Compiles R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112243

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove an unneeded include. #

Total comments: 10

Patch Set 3 : While we're here fixes, and remove unneeded includes. #

Patch Set 4 : Remove callback_forward.h, which was committed as part of a separate CL. #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -10 lines)			Patch
M	chrome/common/service_process_util.h	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/renderer/safe_browsing/malware_dom_details.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome_frame/sync_msg_reply_dispatcher.h	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/base/mock_reader.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/gfx/surface/accelerated_surface_win.h	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	ui/gfx/surface/accelerated_surface_win.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 14 (0 generated)

Expand Messages | Collapse Messages

erikwright (departed)

See this chromium-dev thread for the rationale behind the change: http://goo.gl/I3kob callback_forward.h will be committed ...

9 years ago (2011-11-26 02:39:06 UTC) #1

Ben Goodger (Google)

I'm going to let someone more callbacky like albert take this one. -Ben On Fri, ...

9 years ago (2011-11-27 00:23:21 UTC) #2

I'm going to let someone more callbacky like albert take this one.

-Ben

On Fri, Nov 25, 2011 at 6:39 PM, <erikwright@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> See this chromium-dev thread for the rationale behind the change:
> http://goo.gl/I3kob
>
> callback_forward.h will be committed separately
>
(http://codereview.chromium.**org/8702019/<http://codereview.chromium.org/8702...
> ).
>
> Description:
> Use callback_forward.h instead of callback.h where possible.
>
> callback_forward.h will be committed separately, before this commit, and is
> included here only to assist in running try jobs. It will be removed
> before the
> final commit.
>
> You are asked to review this as you have OWNERS for these files.
>
> BUG=None
> TEST=Compiles
> R=ben@chromium.org
>
>
> Please review this at
http://codereview.chromium.**org/8699008/<http://codereview.chromium.org/8699...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  A base/callback_forward.h
>  M chrome/common/service_process_**util.h
>  M chrome/renderer/safe_browsing/**malware_dom_details.h
>  M chrome_frame/sync_msg_reply_**dispatcher.h
>  M media/base/mock_reader.h
>  M ui/gfx/surface/accelerated_**surface_win.h
>
>
> Index: base/callback_forward.h
> diff --git a/base/callback_forward.h b/base/callback_forward.h
> new file mode 100644
> index 000000000000000000000000000000**0000000000..**
> 0f62864b3181f56264d68b6d453d23**d1005da257
> --- /dev/null
> +++ b/base/callback_forward.h
> @@ -0,0 +1,18 @@
> +// Copyright (c) 2011 The Chromium Authors. All rights reserved.
> +// Use of this source code is governed by a BSD-style license that can be
> +// found in the LICENSE file.
> +
> +#ifndef BASE_CALLBACK_FORWARD_H_
> +#define BASE_CALLBACK_FORWARD_H_
> +#pragma once
> +
> +namespace base {
> +
> +template <typename Sig>
> +class Callback;
> +
> +typedef Callback<void(void)> Closure;
> +
> +}  // namespace base
> +
> +#endif  // BASE_CALLBACK_FORWARD_H
> Index: chrome/common/service_process_**util.h
> diff --git a/chrome/common/service_**process_util.h
> b/chrome/common/service_**process_util.h
> index f9defa5eaaffe5d8cf8e847a69186a**0e21e52643..**
> 74965b8c7e2006a29ca93d960c3893**6bfb17c189 100644
> --- a/chrome/common/service_**process_util.h
> +++ b/chrome/common/service_**process_util.h
> @@ -8,7 +8,7 @@
>  #include <string>
>
>  #include "base/basictypes.h"
> -#include "base/callback.h"
> +#include "base/callback_forward.h"
>  #include "base/memory/scoped_ptr.h"
>  #include "base/process.h"
>  #include "base/shared_memory.h"
> Index: chrome/renderer/safe_browsing/**malware_dom_details.h
> diff --git a/chrome/renderer/safe_**browsing/malware_dom_details.h
> b/chrome/renderer/safe_**browsing/malware_dom_details.h
> index e8eaa5c135e6b041ae08418abd3d53**2ecfccc842..**
> 101f196cb8630cd8afb7f29a7efa0d**803aa39f32 100644
> --- a/chrome/renderer/safe_**browsing/malware_dom_details.h
> +++ b/chrome/renderer/safe_**browsing/malware_dom_details.h
> @@ -13,7 +13,7 @@
>  #include <vector>
>
>  #include "base/basictypes.h"
> -#include "base/callback.h"
> +#include "base/callback_forward.h"
>  #include "base/memory/scoped_ptr.h"
>  #include "base/task.h"
>  #include "content/public/renderer/**render_view_observer.h"
> Index: chrome_frame/sync_msg_reply_**dispatcher.h
> diff --git a/chrome_frame/sync_msg_reply_**dispatcher.h
> b/chrome_frame/sync_msg_reply_**dispatcher.h
> index a1687886bb80ac853547f9270bec35**8aa8d6f2b5..**
> 769c084b1c410c4c22933c68e234a9**c320de9291 100644
> --- a/chrome_frame/sync_msg_reply_**dispatcher.h
> +++ b/chrome_frame/sync_msg_reply_**dispatcher.h
> @@ -7,7 +7,7 @@
>
>  #include <deque>
>
> -#include "base/callback.h"
> +#include "base/callback_forward.h"
>  #include "base/synchronization/lock.h"
>  #include "ipc/ipc_channel_proxy.h"
>
> Index: media/base/mock_reader.h
> diff --git a/media/base/mock_reader.h b/media/base/mock_reader.h
> index a6122a9ce826f41ac05048aa00933a**6eafac43af..**
> 738eb29b06c71258f00c7700e28796**0f34d2ef28 100644
> --- a/media/base/mock_reader.h
> +++ b/media/base/mock_reader.h
> @@ -8,7 +8,7 @@
>  #include <string>
>
>  #include "base/bind.h"
> -#include "base/callback.h"
> +#include "base/callback_forward.h"
>  #include "base/memory/ref_counted.h"
>  #include "media/base/filters.h"
>
> Index: ui/gfx/surface/accelerated_**surface_win.h
> diff --git a/ui/gfx/surface/accelerated_**surface_win.h
> b/ui/gfx/surface/accelerated_**surface_win.h
> index d1fe0699beff84a7d22b84bead9891**31691e3aca..**
> 6cfe41526403859e0e02d91233bfee**2267e71d1d 100644
> --- a/ui/gfx/surface/accelerated_**surface_win.h
> +++ b/ui/gfx/surface/accelerated_**surface_win.h
> @@ -8,7 +8,7 @@
>
>  #include <d3d9.h>
>
> -#include "base/callback.h"
> +#include "base/callback_forward.h"
>  #include "base/memory/ref_counted.h"
>  #include "base/message_loop_proxy.h"
>  #include "base/synchronization/lock.h"
>
>
>

Ami GONE FROM CHROMIUM

drive-by http://codereview.chromium.org/8699008/diff/1/media/base/mock_reader.h File media/base/mock_reader.h (right): http://codereview.chromium.org/8699008/diff/1/media/base/mock_reader.h#newcode11 media/base/mock_reader.h:11: #include "base/callback_forward.h" No longer needed?

9 years ago (2011-11-28 17:27:45 UTC) #4

awong

http://codereview.chromium.org/8699008/diff/7001/chrome/common/service_process_util.h File chrome/common/service_process_util.h (right): http://codereview.chromium.org/8699008/diff/7001/chrome/common/service_process_util.h#newcode20 chrome/common/service_process_util.h:20: class MessageLoopProxy; While we're here, can we un-indent this? ...

9 years ago (2011-11-28 18:42:21 UTC) #5

awong

http://codereview.chromium.org/8699008/diff/7001/ui/gfx/surface/accelerated_surface_win.h File ui/gfx/surface/accelerated_surface_win.h (right): http://codereview.chromium.org/8699008/diff/7001/ui/gfx/surface/accelerated_surface_win.h#newcode34 ui/gfx/surface/accelerated_surface_win.h:34: base::Closure completion_task); This should be const base::Closure&. Would it ...

9 years ago (2011-11-28 18:43:35 UTC) #6

erikwright (departed)

PTAL. Try jobs verifying that it all still works. http://codereview.chromium.org/8699008/diff/1/media/base/mock_reader.h File media/base/mock_reader.h (right): http://codereview.chromium.org/8699008/diff/1/media/base/mock_reader.h#newcode11 media/base/mock_reader.h:11: ...

9 years ago (2011-11-28 19:12:19 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/8699008/13002

9 years ago (2011-11-29 13:19:25 UTC) #9

commit-bot: I haz the power

Presubmit check for 8699008-13002 failed and returned exit status 1. Running presubmit commit checks ...

9 years ago (2011-11-29 13:19:28 UTC) #10

erikwright (departed)

Hi Ben, You or sky@ are needed for the LGTM in ui/ . ajwong's has ...

9 years ago (2011-11-29 13:46:04 UTC) #11

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/8699008/13002

9 years ago (2011-11-30 15:58:44 UTC) #13

Change committed as 112243

Expand Messages | Collapse Messages