Chromium Code Reviews

Issue 8698022: When scavenging update source slot before migrating object it points to. (Closed)

Created:
9 years ago by Vyacheslav Egorov (Chromium)
Modified:
9 years ago
Reviewers:
Erik Corry, Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

When scavenging update source slot before migrating object it points to. Source slot might belong to a dead old object and we might allocate a new object over it when evacuating a new space object this slot points to. In this case if we update slot after migrating object we will write into migrated object. R=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=10082

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+16 lines, -8 lines)
M src/heap.cc View 4 chunks +16 lines, -8 lines 0 comments

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Chromium)
9 years ago (2011-11-28 17:29:32 UTC) #1
Erik Corry
OK, no wonder this was hard to reproduce! LGTM!
9 years ago (2011-11-28 21:19:23 UTC) #2
Michael Starzinger
9 years ago (2011-11-29 09:05:17 UTC) #3
Nice find!

Powered by Google App Engine