Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 8698021: Reduces output & memory usage of compiler by using prototype chain for inherits (Closed)

Created:
9 years ago by zundel
Modified:
9 years ago
Reviewers:
mmendez, codefu
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reduces output & memory usage of compiler by using prototype chain for inherits The setting of $inherits for superclasses in each class is redundant, since this property is set on the prototype. This reduces the JS output of co19 test LangSpecTest/13_Types/13_4_Interface_Types/A11/t01 from 43 MB to 1.6 MB. http://code.google.com/p/dart/issues/detail?id=611 Committed: https://code.google.com/p/dart/source/detail?r=1868

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M compiler/java/com/google/dart/compiler/backend/js/RuntimeTypeInjector.java View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zundel
9 years ago (2011-11-28 16:56:32 UTC) #1
codefu
On 2011/11/28 16:56:32, zundel wrote: LGTM
9 years ago (2011-11-28 17:01:59 UTC) #2
mmendez
9 years ago (2011-11-28 18:13:09 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698