chrome/browser/download/download_request_infobar_delegate_unittest.cc - Issue 8698016: Remove InfoBarDelegate::InfoBarClosed(), delete InfoBars directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_request_infobar_delegate_unittest.cc

Issue 8698016: Remove InfoBarDelegate::InfoBarClosed(), delete InfoBars directly. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc » ('j') | chrome/browser/geolocation/chrome_geolocation_permission_context_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_request_infobar_delegate_unittest.cc

diff --git a/chrome/browser/download/download_request_infobar_delegate_unittest.cc b/chrome/browser/download/download_request_infobar_delegate_unittest.cc

index fdaab1add50e172f286d69a3017fe54e5c959827..219ed09e74ccf1658085417794943c9272202701 100644

--- a/chrome/browser/download/download_request_infobar_delegate_unittest.cc

+++ b/chrome/browser/download/download_request_infobar_delegate_unittest.cc

@@ -22,12 +22,7 @@ class MockTabDownloadState : public DownloadRequestLimiter::TabDownloadState {

return infobar_->AsConfirmInfoBarDelegate();

}

void close_infobar() {

- // TODO(pkasting): Right now InfoBarDelegates delete themselves via

- // InfoBarClosed(); once InfoBars own their delegates, this can become a

- // simple reset() call and ~MockTabDownloadState() will no longer need to

- // call it.

- if (infobar_ != NULL)

- infobar_.release()->InfoBarClosed();

+ infobar_.reset(NULL);

}

bool responded() const { return responded_; }

bool accepted() const { return accepted_; }