Clear cache after showing Sync confirmation bubble

Clear cache after showing Sync confirmation bubble

The sync confirmation bubble would show multiple times.

Fix was to clear the NTP resource cache after the bubble was shown.

BUG=103699
TEST=Verfied that without my patch the sync confirmation bubble would show up multiple times. Applied my patch and verified that the confirmation bubble only showed once.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112371

[Evan Stade, 2011-11-30 03:38:03]

http://codereview.chromium.org/8698010/diff/1/chrome/browser/ui/webui/ntp/ntp...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

http://codereview.chromium.org/8698010/diff/1/chrome/browser/ui/webui/ntp/ntp...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:187:
pref_change_registrar_.Add(prefs::kNTPShownPage, this);
doesn't work to just add kSyncPromoShowNTPBubble here?

[sail, 2011-11-30 05:50:08]

http://codereview.chromium.org/8698010/diff/1/chrome/browser/ui/webui/ntp/ntp...
File chrome/browser/ui/webui/ntp/ntp_resource_cache.cc (right):

http://codereview.chromium.org/8698010/diff/1/chrome/browser/ui/webui/ntp/ntp...
chrome/browser/ui/webui/ntp/ntp_resource_cache.cc:187:
pref_change_registrar_.Add(prefs::kNTPShownPage, this);
On 2011/11/30 03:38:03, Evan Stade wrote:
> doesn't work to just add kSyncPromoShowNTPBubble here?

Done.

Ahh, that works great!

[Evan Stade, 2011-11-30 23:04:33]

lgtm

[commit-bot: I haz the power, 2011-11-30 23:06:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8698010/4001

[commit-bot: I haz the power, 2011-11-30 23:34:04]

Try job failure for 8698010-4001 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2011-11-30 23:47:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sail@chromium.org/8698010/4001

[commit-bot: I haz the power, 2011-12-01 01:45:09]

Change committed as 112371