Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6021)

Unified Diff: chrome/browser/sync/profile_sync_service_autofill_unittest.cc

Issue 8698001: sync: change semantics (and name) of SigninManager::GetUsername (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service_autofill_unittest.cc
diff --git a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
index 9591459848211d8eb7f874c0928d99e0c58d420e..ca6215af40c05aa123d18dd778e92a0149de30f4 100644
--- a/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
+++ b/chrome/browser/sync/profile_sync_service_autofill_unittest.cc
@@ -184,6 +184,18 @@ class WebDataServiceFake : public WebDataService {
return web_database_;
}
+ virtual WebDataService::Handle GetAllTokens(
+ WebDataServiceConsumer* consumer) OVERRIDE {
+ // TODO(tim): It would be nice if WebDataService was injected on
+ // construction of TokenService rather than fetched by Initialize so that
+ // this isn't necessary (we could pass a NULL service). We currently do
+ // return it via EXPECT_CALLs, but without depending on order-of-
+ // initialization (which seems way more fragile) we can't tell which
+ // component is asking at what time, and some components in these Autofill
+ // tests require a WebDataService.
+ return NULL;
+ }
+
virtual AutocompleteSyncableService*
GetAutocompleteSyncableService() const OVERRIDE {
EXPECT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::DB));

Powered by Google App Engine
This is Rietveld 408576698