DownloadManager intereface refactoring to allow cleaner DownloadItem unit tests.

content/browser/download/download_item.h

Index: content/browser/download/download_item.h
diff --git a/content/browser/download/download_item.h b/content/browser/download/download_item.h
index 625d8752bbeaab54458704a704be9d39de3bff4b..c3c646d7f33ef14ea63460420fcb45801ba92108 100644
--- a/content/browser/download/download_item.h
+++ b/content/browser/download/download_item.h
@@ -21,11 +21,11 @@
 #include <string>
 
 #include "base/string16.h"
+#include "content/browser/download/download_id.h"

[cbentzel, 2011/12/02 18:00:52]

Why does this need to be included instead of forward declared as it had? 

[Randy Smith (Not in Mondays), 2011/12/02 20:04:12]

Well, I would have thought a by-value return of the type would require a full
declaration so that the calling code could know how much space to allocate for
the return value.  But I agree with you that the change I'm making here doesn't
look like it should produce a new need for including the file, so even though I
don't understand how the forward decl works: Done.

 #include "content/browser/download/download_state_info.h"
 #include "content/browser/download/interrupt_reasons.h"
 
 class DownloadFileManager;
-class DownloadId;
 class DownloadManager;
 class FilePath;
 class GURL;
@@ -37,6 +37,10 @@ class Time;
 class TimeDelta;
 }
 
+namespace content {
+class BrowserContext;
+}
+
 // One DownloadItem per download. This is the model class that stores all the
 // state for a download. Multiple views, such as a tab's download shelf and the
 // Destination tab's download view, may refer to a given DownloadItem.
@@ -153,6 +157,12 @@ class CONTENT_EXPORT DownloadItem {
   // Called when the downloaded file is removed.
   virtual void OnDownloadedFileRemoved() = 0;
 
+  // If all pre-requisites have been met, complete download processing, i.e.
+  // do internal cleanup, file rename, and potentially auto-open.
+  // (Dangerous downloads still may block on user acceptance after this
+  // point.)
+  virtual void MaybeCompleteDownload() = 0;
+
   // Download operation had an error.
   // |size| is the amount of data received at interruption.
   // |reason| is the download interrupt reason code that the operation received.
@@ -247,7 +257,6 @@ class CONTENT_EXPORT DownloadItem {
   virtual base::Time GetEndTime() const = 0;
   virtual void SetDbHandle(int64 handle) = 0;
   virtual int64 GetDbHandle() const = 0;
-  virtual DownloadManager* GetDownloadManager() = 0;
   virtual bool IsPaused() const = 0;
   virtual bool GetOpenWhenComplete() const = 0;
   virtual void SetOpenWhenComplete(bool open) = 0;
@@ -272,6 +281,7 @@ class CONTENT_EXPORT DownloadItem {
   virtual InterruptReason GetLastReason() const = 0;
   virtual DownloadPersistentStoreInfo GetPersistentStoreInfo() const = 0;
   virtual DownloadStateInfo GetStateInfo() const = 0;
+  virtual content::BrowserContext* BrowserContext() const = 0;
   virtual TabContents* GetTabContents() const = 0;
 
   // Returns the final target file path for the download.