Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: chrome/browser/download/download_shelf_context_menu.cc

Issue 8697006: DownloadManager intereface refactoring to allow cleaner DownloadItem unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added CONTENT_EXPORT to delegate. Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/download/download_prefs.cc ('k') | content/browser/download/download_item.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/download/download_shelf_context_menu.h" 5 #include "chrome/browser/download/download_shelf_context_menu.h"
6 6
7 #include "chrome/browser/download/download_item_model.h" 7 #include "chrome/browser/download/download_item_model.h"
8 #include "chrome/browser/download/download_prefs.h" 8 #include "chrome/browser/download/download_prefs.h"
9 #include "chrome/browser/google/google_util.h" 9 #include "chrome/browser/google/google_util.h"
10 #include "chrome/browser/ui/browser_list.h" 10 #include "chrome/browser/ui/browser_list.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 74
75 void DownloadShelfContextMenu::ExecuteCommand(int command_id) { 75 void DownloadShelfContextMenu::ExecuteCommand(int command_id) {
76 switch (command_id) { 76 switch (command_id) {
77 case SHOW_IN_FOLDER: 77 case SHOW_IN_FOLDER:
78 download_item_->ShowDownloadInShell(); 78 download_item_->ShowDownloadInShell();
79 break; 79 break;
80 case OPEN_WHEN_COMPLETE: 80 case OPEN_WHEN_COMPLETE:
81 download_item_->OpenDownload(); 81 download_item_->OpenDownload();
82 break; 82 break;
83 case ALWAYS_OPEN_TYPE: { 83 case ALWAYS_OPEN_TYPE: {
84 DownloadPrefs* prefs = DownloadPrefs::FromDownloadManager( 84 DownloadPrefs* prefs = DownloadPrefs::FromBrowserContext(
85 download_item_->GetDownloadManager()); 85 download_item_->BrowserContext());
86 FilePath path = download_item_->GetUserVerifiedFilePath(); 86 FilePath path = download_item_->GetUserVerifiedFilePath();
87 if (!IsCommandIdChecked(ALWAYS_OPEN_TYPE)) 87 if (!IsCommandIdChecked(ALWAYS_OPEN_TYPE))
88 prefs->EnableAutoOpenBasedOnExtension(path); 88 prefs->EnableAutoOpenBasedOnExtension(path);
89 else 89 else
90 prefs->DisableAutoOpenBasedOnExtension(path); 90 prefs->DisableAutoOpenBasedOnExtension(path);
91 break; 91 break;
92 } 92 }
93 case CANCEL: 93 case CANCEL:
94 download_model_->CancelTask(); 94 download_model_->CancelTask();
95 break; 95 break;
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
211 malicious_download_menu_model_->AddItemWithStringId( 211 malicious_download_menu_model_->AddItemWithStringId(
212 DISCARD, IDS_DOWNLOAD_MENU_DISCARD); 212 DISCARD, IDS_DOWNLOAD_MENU_DISCARD);
213 malicious_download_menu_model_->AddItemWithStringId( 213 malicious_download_menu_model_->AddItemWithStringId(
214 KEEP, IDS_DOWNLOAD_MENU_KEEP); 214 KEEP, IDS_DOWNLOAD_MENU_KEEP);
215 malicious_download_menu_model_->AddSeparator(); 215 malicious_download_menu_model_->AddSeparator();
216 malicious_download_menu_model_->AddItemWithStringId( 216 malicious_download_menu_model_->AddItemWithStringId(
217 LEARN_MORE, IDS_DOWNLOAD_MENU_LEARN_MORE); 217 LEARN_MORE, IDS_DOWNLOAD_MENU_LEARN_MORE);
218 218
219 return malicious_download_menu_model_.get(); 219 return malicious_download_menu_model_.get();
220 } 220 }
OLDNEW
« no previous file with comments | « chrome/browser/download/download_prefs.cc ('k') | content/browser/download/download_item.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698