chrome/browser/net/gaia/token_service_unittest.cc - Issue 8696001: Removing SignalingTask and replace with base::Bind(&WaitableEvent::Signal, ...)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/gaia/token_service_unittest.cc

Issue 8696001: Removing SignalingTask and replace with base::Bind(&WaitableEvent::Signal, ...) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/test_extension_prefs.cc ('k') | chrome/browser/password_manager/password_store_default_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/gaia/token_service_unittest.cc

diff --git a/chrome/browser/net/gaia/token_service_unittest.cc b/chrome/browser/net/gaia/token_service_unittest.cc

index 54c001bb50a2f0d8ef6167ec25fd028f2eab52d4..f70888bc33bd70f6f65928496e2aaff8926635a7 100644

--- a/chrome/browser/net/gaia/token_service_unittest.cc

+++ b/chrome/browser/net/gaia/token_service_unittest.cc

@@ -6,9 +6,10 @@

#include "chrome/browser/net/gaia/token_service_unittest.h"

+#include "base/bind.h"

+#include "base/bind_helpers.h"

#include "base/command_line.h"

#include "base/synchronization/waitable_event.h"

-#include "base/test/signaling_task.h"

#include "chrome/browser/password_manager/encryptor.h"

#include "chrome/common/chrome_notification_types.h"

#include "chrome/common/chrome_switches.h"

@@ -97,7 +98,9 @@ void TokenServiceTestHarness::WaitForDBLoadCompletion() {

// operations should be complete.

base::WaitableEvent done(false, false);

BrowserThread::PostTask(

- BrowserThread::DB, FROM_HERE, new base::SignalingTask(&done));

+ BrowserThread::DB,

+ FROM_HERE,

+ base::Bind(&base::WaitableEvent::Signal, base::Unretained(&done)));

done.Wait();

// Notifications should be returned from the DB thread onto the UI thread.