Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: chrome/browser/extensions/test_extension_prefs.cc

Issue 8696001: Removing SignalingTask and replace with base::Bind(&WaitableEvent::Signal, ...) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/test/signaling_task.cc ('k') | chrome/browser/net/gaia/token_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/test_extension_prefs.cc
diff --git a/chrome/browser/extensions/test_extension_prefs.cc b/chrome/browser/extensions/test_extension_prefs.cc
index a95be5982a92f5373fb295b0f6b3a7203fd0e71c..cccbdecc2bf6d80e3c8dba72a38579034eabd963 100644
--- a/chrome/browser/extensions/test_extension_prefs.cc
+++ b/chrome/browser/extensions/test_extension_prefs.cc
@@ -4,12 +4,13 @@
#include "chrome/browser/extensions/test_extension_prefs.h"
+#include "base/bind.h"
+#include "base/bind_helpers.h"
#include "base/file_util.h"
#include "base/memory/scoped_ptr.h"
#include "base/message_loop.h"
#include "base/message_loop_proxy.h"
#include "base/synchronization/waitable_event.h"
-#include "base/test/signaling_task.h"
#include "base/values.h"
#include "chrome/browser/extensions/extension_pref_store.h"
#include "chrome/browser/extensions/extension_pref_value_map.h"
@@ -73,8 +74,11 @@ void TestExtensionPrefs::RecreateExtensionPrefs() {
// PrefService.
base::WaitableEvent io_finished(false, false);
pref_service_->SavePersistentPrefs();
- EXPECT_TRUE(BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE,
- new base::SignalingTask(&io_finished)));
+ EXPECT_TRUE(BrowserThread::PostTask(
+ BrowserThread::FILE,
+ FROM_HERE,
+ base::Bind(&base::WaitableEvent::Signal,
+ base::Unretained(&io_finished))));
// If the FILE thread is in fact the current thread (possible in testing
// scenarios), we have to ensure the task has a chance to run. If the FILE
« no previous file with comments | « base/test/signaling_task.cc ('k') | chrome/browser/net/gaia/token_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698