Issue 8696001: Removing SignalingTask and replace with base::Bind(&WaitableEvent::Signal, ...)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8696001: Removing SignalingTask and replace with base::Bind(&WaitableEvent::Signal, ...) (Closed)

Created:
9 years, 1 month ago by dcheng

Modified:
9 years ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, akalin, ncarter (slow), Raghu Simha, Erik does not do reviews, brettw-cc_chromium.org, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, Paweł Hajdan Jr., tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Removing SignalingTask and replace with base::Bind(&WaitableEvent::Signal, ...) BUG=none TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111603

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -90 lines)			Patch
M	base/base.gyp	View		1 chunk	+0 lines, -2 lines	0 comments	Download
D	base/test/signaling_task.h	View		1 chunk	+0 lines, -31 lines	0 comments	Download
D	base/test/signaling_task.cc	View		1 chunk	+0 lines, -20 lines	0 comments	Download
M	chrome/browser/extensions/test_extension_prefs.cc	View	1 2 3	2 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/net/gaia/token_service_unittest.cc	View	1 2 3 4	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_default_unittest.cc	View		10 chunks	+11 lines, -10 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_win_unittest.cc	View	1 2 3 4	7 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/password_manager/password_store_x_unittest.cc	View		13 chunks	+12 lines, -12 lines	0 comments	Download
M	chrome/browser/sync/signin_manager_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/test/webrtc_audio_device_test.cc	View	1 2	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/8696001/8001

9 years ago (2011-11-25 18:16:46 UTC) #3

commit-bot: I haz the power

9 years ago (2011-11-25 18:16:57 UTC) #4

Presubmit check for 8696001-8001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: chrome/browser/sync/signin_manager_unittest.cc

Presubmit checks took 1.5s to calculate.

Expand Messages | Collapse Messages