Let fake UI allow a video capture device to be opened several times.

content/browser/renderer_host/media/media_stream_device_settings.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/media/media_stream_device_settings.h"
 
 #include "base/stl_util.h"
 #include "base/task.h"
 #include "content/browser/renderer_host/media/media_stream_settings_requester.h"
 #include "content/common/media/media_stream_options.h"
@@ skipping 105 matching lines @@
       StreamDeviceInfoArray devices_to_use;
       for (DeviceMap::iterator it = request->devices.begin();
            it != request->devices.end(); ++it) {
         for (StreamDeviceInfoArray::iterator device_it = it->second.begin();
              device_it != it->second.end(); ++device_it) {
           if (!device_it->in_use) {
             devices_to_use.push_back(*device_it);
             break;
           }
         }
       }

[wjia(left Chromium), 2011/11/24 20:44:29]

I was thinking of a simple way: remove the inner for loop above and replace it
with
devices_to_use.push_back(*(it->second.begin()));

In other words, it will pick up the first device in the list for both audio and
video, regardless of "in_use". Since this is just a "faked" UI, there would be
many ways to do it.

What do you think?

[mflodman_chromium_OOO, 2011/11/25 08:37:42]

I thought about that too, but that would remove the possibility to test
MediaStreamDispatcherHost with multiple devices and also different cameras on
different tabs before the real UI is in place. I know the code gets more complex
this way, but I think it is worth it anyway for the testing.

Agree/disagree?

+      if (num_media_requests != devices_to_use.size()) {
+        // Not all requested device types were opened. This happens if all
+        // video capture devices are already opened, |in_use| isn't set for
+        // audio devices. Allow the first video capture device in the list to be
+        // opened for this user too.
+        DCHECK(request->options.video_option != StreamOptions::kNoCamera);

[scherkus (not reviewing), 2011/11/29 02:39:53]

DCHECK_NE

[mflodman_chromium_OOO, 2011/11/29 23:31:00]

Done.

+        StreamDeviceInfoArray device_array = (request->devices[kVideoCapture]);
+        devices_to_use.push_back(*(device_array.begin()));
+      }
+
       // Post result and delete request.
       requester_->DevicesAccepted(label, devices_to_use);
       requests_.erase(request_it);
       delete request;
     }
   }
 }
 
 void MediaStreamDeviceSettings::UseFakeUI() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   use_fake_ui_ = true;
 }
 
 }  // namespace media_stream