Issue 8694002: Protector: string and fix segfault fix on button press.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8694002: Protector: string and fix segfault fix on button press. (Closed)

Created:
9 years ago by Ivan Korotkov

Modified:
9 years ago

Reviewers:
whywhat

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Protector: string and fix segfault fix on button press. BUG=105330 TEST=Manual: click on any of the Protector bubble buttons should not crash the browser. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111555

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -13 lines)			Patch
	M	chrome/app/generated_resources.grd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
	M	chrome/browser/protector/default_search_provider_change.cc	View	1	5 chunks	+9 lines, -6 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ivankr@chromium.org/8694002/1003

9 years ago (2011-11-24 19:10:09 UTC) #3

Change committed as 111555