Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 8694001: set type 'settings' to 'none' in gyp file in case using the system lib (Closed)

Created:
9 years, 1 month ago by Robert Nagy
Modified:
9 years, 1 month ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

set type 'settings' to 'none' in gyp file in case using the system lib BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111529

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/libevent/libevent.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
No reviewers yet.
9 years, 1 month ago (2011-11-24 14:15:30 UTC) #1
Robert Nagy
9 years, 1 month ago (2011-11-24 14:15:58 UTC) #2
Mark Mentovai
LGTM and CQ.
9 years, 1 month ago (2011-11-24 14:17:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robert.nagy@gmail.com/8694001/1
9 years, 1 month ago (2011-11-24 14:17:23 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-24 15:12:54 UTC) #5
Change committed as 111529

Powered by Google App Engine
This is Rietveld 408576698