Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 8694: Fix issue with Array.concat not preserving holes in the (Closed)

Created:
12 years, 1 month ago by Kasper Lund
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Fix issue with Array.concat not preserving holes in the top-level arrays. Committed: http://code.google.com/p/v8/source/detail?r=635

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -15 lines) Patch
M src/factory.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/factory.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/runtime.cc View 2 chunks +15 lines, -11 lines 0 comments Download
M test/mjsunit/array-concat.js View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kasper Lund
12 years, 1 month ago (2008-10-29 09:50:53 UTC) #1
Erik Corry
12 years, 1 month ago (2008-10-29 09:56:09 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698