chrome/common/extensions/extension_l10n_util_unittest.cc - Issue 8693005: Remove potentially many static initializers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension_l10n_util_unittest.cc

Issue 8693005: Remove potentially many static initializers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension_l10n_util_unittest.cc

diff --git a/chrome/common/extensions/extension_l10n_util_unittest.cc b/chrome/common/extensions/extension_l10n_util_unittest.cc

index bedbd5230b73c87add0c7463af3ba52ea17ec75a..9d4f868beb20f6f61a1df3d499aded2b43b6fe9e 100644

--- a/chrome/common/extensions/extension_l10n_util_unittest.cc

+++ b/chrome/common/extensions/extension_l10n_util_unittest.cc

@@ -257,7 +257,7 @@ TEST(ExtensionL10nUtil, LocalizeEmptyManifest) {

EXPECT_FALSE(

extension_l10n_util::LocalizeManifest(*messages, &manifest, &error));

- EXPECT_EQ(errors::kInvalidName, error);

+ EXPECT_EQ(std::string(errors::kInvalidName), error);

Ryan Sleevi 2011/11/24 20:13:59 EXPECT_STREQ ?

}

TEST(ExtensionL10nUtil, LocalizeManifestWithoutNameMsgAndEmptyDescription) {