Remove potentially many static initializers.

Remove potentially many static initializers.

|const char* kFoo| marks the memory pointed to by kFoo as constant, but
the pointer itself can be changed - some function might do `kFoo = "me!";`.
Because of that, every global that's initialized with `myglobal = kFoo;` needs
a static initializer. Fix this by making the pointer const as well.

BUG=94925
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111559

[Ryan Sleevi, 2011-11-24 20:13:58]

LGTM.

I suppose alternatively the "const char* const kFoo" approach would have worked,
but I certainly prefer const char kFoo[] myself, so enthusiastic +1.

One suggestion with the string comparisons below - I haven't used EXPECT_STREQ
personally, but it seems to be what you're looking for, rather than the string
wrapping.

http://codereview.chromium.org/8693005/diff/5001/chrome/common/extensions/ext...
File chrome/common/extensions/extension_l10n_util_unittest.cc (right):

http://codereview.chromium.org/8693005/diff/5001/chrome/common/extensions/ext...
chrome/common/extensions/extension_l10n_util_unittest.cc:260:
EXPECT_EQ(std::string(errors::kInvalidName), error);
EXPECT_STREQ ?

http://codereview.chromium.org/8693005/diff/5001/chrome/common/extensions/ext...
File chrome/common/extensions/extension_manifests_unittest.cc (right):

http://codereview.chromium.org/8693005/diff/5001/chrome/common/extensions/ext...
chrome/common/extensions/extension_manifests_unittest.cc:936:
EXPECT_EQ(std::string(errors::kInvalidChromeURLOverrides), error);
EXPECT_STREQ

http://codereview.chromium.org/8693005/diff/5001/chrome/common/extensions/ext...
File chrome/common/extensions/extension_unpacker_unittest.cc (right):

http://codereview.chromium.org/8693005/diff/5001/chrome/common/extensions/ext...
chrome/common/extensions/extension_unpacker_unittest.cc:51:
EXPECT_EQ(std::string(errors::kInvalidDefaultLocale),
EXPECT_STREQ 

etc, etc

[Nico, 2011-11-24 20:18:11]

Much nicer, thanks! Let's see if this compiles :-)

http://codereview.chromium.org/8693005/diff/5001/chrome/common/extensions/ext...
File chrome/common/extensions/extension_unpacker_unittest.cc (right):

http://codereview.chromium.org/8693005/diff/5001/chrome/common/extensions/ext...
chrome/common/extensions/extension_unpacker_unittest.cc:51:
EXPECT_EQ(std::string(errors::kInvalidDefaultLocale),
On 2011/11/24 20:13:59, Ryan Sleevi wrote:
> EXPECT_STREQ 
> 
> etc, etc

Done.

[Nico, 2011-11-24 20:31:59]

As discussed on IRC, CmpHelperSTREQ() doesn't have a char*, string override. So
back to patch set 4.

[commit-bot: I haz the power, 2011-11-24 20:32:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/8693005/3003

[commit-bot: I haz the power, 2011-11-24 21:37:03]

Change committed as 111559