Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 8692007: Fix error message when using "gcl try nonexistentcl". (Closed)

Created:
9 years ago by Alexei Svitkine (slow)
Modified:
9 years ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Fix error message when using "gcl try nonexistentcl". Call ChangeInfo.Load() with fail_on_not_found=True to get a good error message in this case. BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gcl.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Alexei Svitkine (slow)
9 years ago (2011-11-29 20:28:00 UTC) #1
M-A Ruel
lgtm
9 years ago (2011-11-29 20:29:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/8692007/1
9 years ago (2011-11-29 20:29:34 UTC) #3
commit-bot: I haz the power
Change committed as 112018
9 years ago (2011-11-29 20:36:17 UTC) #4
achuithb
9 years ago (2011-11-30 20:28:12 UTC) #5
This breaks try requests of the format:
gcl try -R codereview.chromium.org/8000000

Powered by Google App Engine
This is Rietveld 408576698