Fix for cant reopen file dialog after close it by x button or alt+f4

chrome/browser/ui/views/extensions/extension_dialog.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/extensions/extension_dialog.h"
 
 #include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
@@ skipping 95 matching lines @@
 }
 
 void ExtensionDialog::ObserverDestroyed() {
   observer_ = NULL;
 }
 
 void ExtensionDialog::Close() {
   if (!window_)
     return;
 
-  if (observer_)
-    observer_->ExtensionDialogIsClosing(this);
-
   window_->Close();
   window_ = NULL;
 }
 
 /////////////////////////////////////////////////////////////////////////////
 // views::WidgetDelegate overrides.
 
 bool ExtensionDialog::CanResize() const {
   return false;
 }
 
 bool ExtensionDialog::IsModal() const {
   return true;
 }
 
 bool ExtensionDialog::ShouldShowWindowTitle() const {
   return !window_title_.empty();
 }
 
 string16 ExtensionDialog::GetWindowTitle() const {
   return window_title_;
 }
 
+void ExtensionDialog::WindowClosing() {
+  // Cleanup the pending dialog list.

[flackr, 2011/11/28 19:47:06]

Correct me if I'm wrong, but your comment is specific to the file selector
dialog, right? I think the code is fairly self documenting, in that anything you
write wouldn't be any more specific than just reading that the observer is
notified of the window closing. So in this case remove the comment.

[bshe, 2011/11/28 22:26:50]

Done.
It is quite self documenting, so I will just remove it.

On 2011/11/28 19:47:06, flackr wrote:

+  if (observer_)
+    observer_->ExtensionDialogIsClosing(this);
+}
+
 void ExtensionDialog::DeleteDelegate() {
   // The window has finished closing.  Allow ourself to be deleted.
   Release();
 }
 
 views::Widget* ExtensionDialog::GetWidget() {
   return extension_host_->view()->GetWidget();
 }
 
 const views::Widget* ExtensionDialog::GetWidget() const {
@@ skipping 15 matching lines @@
       // If we aren't the host of the popup, then disregard the notification.
       if (content::Details<ExtensionHost>(host()) != details)
         return;
       Close();
       break;
     default:
       NOTREACHED() << L"Received unexpected notification";
       break;
   }
 }