Fix for cant reopen file dialog after close it by x button or alt+f4

chrome/browser/ui/views/select_file_dialog_extension.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/select_file_dialog_extension.h"
 
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/singleton.h"
 #include "chrome/browser/extensions/extension_file_browser_private_api.h"
@@ skipping 194 matching lines @@
     NOTREACHED() << "Can't find owning browser";
     return;
   }
 
   TabContentsWrapper* tab = owner_browser->GetSelectedTabContentsWrapper();
 
   // Check if we have another dialog opened in the tab. It's unlikely, but
   // possible.
   int32 tab_id = tab ? tab->restore_tab_helper()->session_id().id() : 0;
   if (PendingExists(tab_id))
-    return;
+    PendingDialog::GetInstance()->Remove(tab_id);

[Rick Byers, 2011/11/25 15:06:06]

I haven't looked at the code in detail, but doesn't this just circumvent what
PendingDialog was trying to do (make sure you never have two dialogs up at
once)?

[bshe, 2011/11/25 17:58:49]

I am not sure when and how a user attempts to open two dialogs in the same tab.
I was think maybe we can give user some sort of feedback (bring the previous one
up or delete previous one and create a new one or a warning dialog) when they
try to do so instead of just ignore. But I guess it depends on the specific
situation. Maybe ignore its exactly what we want. 

Also giving some sort of feedback may require some works, if the situation is
rare, it might not worth to spend time on it at least for now.

Anyway, I am working on making the close button behaves the same as cancel
button.
 

On 2011/11/25 15:06:06, Rick Byers wrote:

 
   FilePath virtual_path;
   if (!file_manager_util::ConvertFileToRelativeFileSystemPath(
           owner_browser->profile(), default_path, &virtual_path)) {
     virtual_path = default_path.BaseName();
   }
 
   hasMultipleFileTypeChoices_ =
       file_types ? file_types->extensions.size() > 1 : true;
 
@@ skipping 11 matching lines @@
   }
 
   // Connect our listener to FileDialogFunction's per-tab callbacks.
   AddPending(tab_id);
 
   extension_dialog_ = dialog;
   params_ = params;
   tab_id_ = tab_id;
   owner_window_ = owner_window;
 }