Issue 8692002: Only sweep one page eagerly unless we are running out of space.

Issue 8692002: Only sweep one page eagerly unless we are running out of space. (Closed)

Created:
9 years, 1 month ago by Erik Corry

Modified:
9 years ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Only sweep one page eagerly unless we are running out of space. Limit the number of pages that are compacted in a given GC. Committed: http://code.google.com/p/v8/source/detail?r=10084

Patch Set 2 : '' #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+235 lines, -109 lines)			Patch
M	src/heap.h	View		1 chunk	+7 lines, -1 line	0 comments	Download
M	src/heap.cc	View		1 chunk	+13 lines, -1 line	0 comments	Download
M	src/mark-compact.cc	View	1	7 chunks	+183 lines, -95 lines	0 comments	Download
M	src/objects.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/spaces.h	View	1	4 chunks	+14 lines, -8 lines	0 comments	Download
M	src/spaces.cc	View	1	4 chunks	+17 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with nits). http://codereview.chromium.org/8692002/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/8692002/diff/1/src/mark-compact.cc#newcode421 src/mark-compact.cc:421: int number_of_pages = 0; Can we ...

9 years, 1 month ago (2011-11-24 14:43:49 UTC) #2

Erik Corry

9 years, 1 month ago (2011-11-24 17:02:30 UTC) #3

http://codereview.chromium.org/8692002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

http://codereview.chromium.org/8692002/diff/1/src/mark-compact.cc#newcode421
src/mark-compact.cc:421: int number_of_pages = 0;
On 2011/11/24 14:43:49, Michael Starzinger wrote:
> Can we instead use PagedSpace::CountTotalPages() and make that available for
> non-debug builds instead?

Done.

http://codereview.chromium.org/8692002/diff/1/src/mark-compact.cc#newcode432
src/mark-compact.cc:432: const int kMaxMaxEvacuationCandidates = 1000;
On 2011/11/24 14:43:49, Michael Starzinger wrote:
> Why two 'Max' in that constant?

You can't make the max any higher than this.  Fixed so that this is actually
enforced for 2 terabyte heaps!

http://codereview.chromium.org/8692002/diff/1/src/spaces.h
File src/spaces.h (right):

http://codereview.chromium.org/8692002/diff/1/src/spaces.h#newcode1573
src/spaces.h:1573: int Fragmentation(Page* p) {
On 2011/11/24 14:43:49, Michael Starzinger wrote:
> A one-liner comment about the possible range of return values would be nice
> here.

Done.

Expand Messages | Collapse Messages