Issue 8690007: Revert 111566 - Breaks compile on win dbg.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8690007: Revert 111566 - Breaks compile on win dbg. (Closed)

Created:
9 years ago by koz (OOO until 15th September)

Modified:
9 years ago

Reviewers:
Ryan Sleevi

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr., jam, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Revert 111566 - Breaks compile on win dbg. Add a referrer class to be used in the browser process whenever passing around referrers TBR=jochen Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111574

Patch Set 1 #

Patch Set 2 : revert #

Created: 9 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -58 lines)			Patch
D	content/common/referrer_unittest.cc	View	1 chunk	+0 lines, -23 lines	0 comments	Download
M	content/content_common.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/content_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	content/public/common/referrer.h	View	1 chunk	+0 lines, -33 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Ryan Sleevi

9 years ago (2011-11-25 03:49:47 UTC) #1

Clarification: It breaks compile on win_shared

The reason for this is nothing that is linked into content.dll currently
includes referrer.h (because there is no .cc and because there are no consumers
of referrer.h in content)

As a result, the CONTENT_EXPORT is basically a statement that certain symbols
are exported - but they are, in fact, inlined into every module that includes
that .h. In this case, content_unittests

Your original CL had a .cc, which is mostly correct (you'd need to add a dtor
and a copy ctor, since the compiler's auto-generation will put them back into
the linking module, not content.dll). If you drop the CONTENT_EXPORT, I believe
that will cause issues with the ODR rule for the _shared bots.

Or just include referrer.h (and use ctor, dtor, and copy ctor) in an object file
linked in content. But that feels wrong on so many levels - and can easily break
on refactor.

Expand Messages | Collapse Messages