Issue 8690006: Revert 111548 - Broke OmniboxViewTest.AcceptKeywordBySpace on Linux

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8690006: Revert 111548 - Broke OmniboxViewTest.AcceptKeywordBySpace on Linux (Closed)

Created:
9 years, 1 month ago by Ryan Sleevi

Modified:
9 years, 1 month ago

Reviewers:
SanjoyPal

CC:
chromium-reviews, James Su, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 111548 - Broke OmniboxViewTest.AcceptKeywordBySpace on Linux Strip invalid characters (line breaks, tabs), javascript:schemes from the copied text while pasting text, droping text and creating right click popup for omnibox. BUG=82181, 103703 . TEST=Copy a string with line breaks "\n" or tabs "\t". Then right click on omnibox. Chromium should not trigger DCHECKS. Review URL: http://codereview.chromium.org/8513002 TBR=ncj674@motorola.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111558

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -28 lines)			Patch
M	base/utf_string_conversion_utils.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autocomplete/autocomplete_edit.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc	View	7 chunks	+19 lines, -24 lines	0 comments	Download

Total messages: 1 (0 generated)