Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 8690005: Remove 4 static initializers. (Closed)

Created:
9 years, 1 month ago by Nico
Modified:
9 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, ncarter (slow), akalin, Raghu Simha, Erik does not do reviews, mihaip+watch_chromium.org, Aaron Boodman, tim (not reviewing)
Visibility:
Public.

Description

Remove 4 static initializers. Most of them caused by gcc 4.4 being not sufficiently smart. BUG=94925 TEST=none TBR=akalin Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111560

Patch Set 1 #

Total comments: 2

Patch Set 2 : cin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M chrome/browser/bookmarks/bookmark_extension_api.cc View 2 chunks +9 lines, -14 lines 0 comments Download
M chrome/browser/sync/syncable/directory_backing_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/connection.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Sleevi
LGTM, mod comment below. http://codereview.chromium.org/8690005/diff/1/chrome/browser/sync/syncable/directory_backing_store.cc File chrome/browser/sync/syncable/directory_backing_store.cc (left): http://codereview.chromium.org/8690005/diff/1/chrome/browser/sync/syncable/directory_backing_store.cc#oldcode33 chrome/browser/sync/syncable/directory_backing_store.cc:33: const int kDirectoryBackingStoreBusyTimeoutMs = std::numeric_limits<int>::max(); ...
9 years, 1 month ago (2011-11-24 20:41:22 UTC) #1
Nico
Thanks! http://codereview.chromium.org/8690005/diff/1/chrome/browser/sync/syncable/directory_backing_store.cc File chrome/browser/sync/syncable/directory_backing_store.cc (left): http://codereview.chromium.org/8690005/diff/1/chrome/browser/sync/syncable/directory_backing_store.cc#oldcode33 chrome/browser/sync/syncable/directory_backing_store.cc:33: const int kDirectoryBackingStoreBusyTimeoutMs = std::numeric_limits<int>::max(); On 2011/11/24 20:41:23, ...
9 years, 1 month ago (2011-11-24 20:42:17 UTC) #2
Nico
akalin, OWNERS stamp for the sync file please
9 years, 1 month ago (2011-11-24 20:42:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8690005/1
9 years, 1 month ago (2011-11-24 20:42:53 UTC) #4
commit-bot: I haz the power
Try job failure for 8690005-1 (retry) on linux_rel for step "compile" (clobber build). It's a ...
9 years, 1 month ago (2011-11-24 21:06:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8690005/4001
9 years, 1 month ago (2011-11-24 21:25:14 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-24 22:30:28 UTC) #7
Change committed as 111560

Powered by Google App Engine
This is Rietveld 408576698