Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 8689014: Move P2P unit tests to content_unittests (Closed)

Created:
9 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
9 years, 1 month ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org, Sergey Ulanov
Visibility:
Public.

Description

Move P2P unit tests to content_unittests Also fix uninitialized memory in the jingle thread wrapper BUG=10502 TEST=content_unittests, valgrind is happy Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M chrome/chrome_tests.gypi View 2 chunks +0 lines, -10 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +10 lines, -0 lines 0 comments Download
M jingle/glue/thread_wrapper.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
I reverted since the memory bots turned red. John, can you re-review plz?
9 years, 1 month ago (2011-11-24 22:48:41 UTC) #1
jochen (gone - plz use gerrit)
I reverted since the memory bots turned red. John, can you re-review plz?
9 years, 1 month ago (2011-11-24 22:48:45 UTC) #2
jam
lgtm
9 years, 1 month ago (2011-11-24 22:49:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/8689014/1
9 years, 1 month ago (2011-11-24 22:54:23 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-25 00:14:34 UTC) #5
Change committed as 111568

Powered by Google App Engine
This is Rietveld 408576698