Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1505)

Unified Diff: content/browser/gamepad/gamepad_provider.cc

Issue 8689012: Message receiver on browser side that holds/starts the gamepad data provider (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: newline at eof Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/gamepad/gamepad_provider.cc
diff --git a/content/browser/gamepad/gamepad_provider.cc b/content/browser/gamepad/gamepad_provider.cc
index 642e2445a7bbe8fa0d0fc8fa7fd1fcbe2827c101..d8e8df88a7bdcf6a7fdeb026889721003cf9f77a 100644
--- a/content/browser/gamepad/gamepad_provider.cc
+++ b/content/browser/gamepad/gamepad_provider.cc
@@ -23,8 +23,6 @@
namespace gamepad {
-Provider* Provider::instance_ = NULL;
-
using namespace content;
// Define the default data fetcher that Provider will use if none is supplied.
@@ -99,6 +97,9 @@ void Provider::Start() {
void Provider::Stop() {
DCHECK(MessageLoop::current()->message_loop_proxy() == creator_loop_);
+ // TODO(scottmg): Don't join the thread. See crbug.com/72286.
+ base::ThreadRestrictions::ScopedAllowIO allow_io;
jam 2011/11/24 23:16:02 hmm, no way to avoid this in this cl? these usage
+
polling_thread_.reset();
data_fetcher_.reset();
}

Powered by Google App Engine
This is Rietveld 408576698