Message receiver on browser side that holds/starts the gamepad data provider

Message receiver on browser side that holds/starts the gamepad data provider

Messages are already committed, and the patch that sends the messages from the
renderer side is here: http://codereview.chromium.org/8689011/ (at the top of
content/renderer/gamepad_util.cc)

re: AllowScopedIO in Stop(), I copied startup/shutdown from somewhere that I
didn't realize had that problem. Will follow up to figure out how to shut down
cleanly.

BUG=79050
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111624

[jam, 2011-11-24 23:16:02]

http://codereview.chromium.org/8689012/diff/2002/content/browser/gamepad/game...
File content/browser/gamepad/gamepad_provider.cc (right):

http://codereview.chromium.org/8689012/diff/2002/content/browser/gamepad/game...
content/browser/gamepad/gamepad_provider.cc:101:
base::ThreadRestrictions::ScopedAllowIO allow_io;
hmm, no way to avoid this in this cl? these usage tend to creep in and be low
priority to remove :)

http://codereview.chromium.org/8689012/diff/2002/content/browser/renderer_hos...
File content/browser/renderer_host/gamepad_browser_message_filter.cc (right):

http://codereview.chromium.org/8689012/diff/2002/content/browser/renderer_hos...
content/browser/renderer_host/gamepad_browser_message_filter.cc:22:
IPC_MESSAGE_HANDLER_DELAY_REPLY(GamepadHostMsg_StartPolling,
you only need to use IPC_MESSAGE_HANDLER_DELAY_REPLY when the sync message can't
be responded to in the dispatcher function. in these cases, you don't need it
since you always have the result ready. see
http://www.chromium.org/developers/design-documents/inter-process-communication

http://codereview.chromium.org/8689012/diff/2002/content/browser/renderer_hos...
File content/browser/renderer_host/gamepad_browser_message_filter.h (right):

http://codereview.chromium.org/8689012/diff/2002/content/browser/renderer_hos...
content/browser/renderer_host/gamepad_browser_message_filter.h:13: : public
BrowserMessageFilter {
nit: can fit on one line

http://codereview.chromium.org/8689012/diff/2002/content/browser/renderer_hos...
content/browser/renderer_host/gamepad_browser_message_filter.h:27: };
nit: add DISALLOW_COPY_AND_ASSIGN

http://codereview.chromium.org/8689012/diff/2002/content/content_browser.gypi
File content/content_browser.gypi (right):

http://codereview.chromium.org/8689012/diff/2002/content/content_browser.gypi...
content/content_browser.gypi:371:
'browser/renderer_host/gamepad_browser_message_filter.cc',
nit: order

[scottmg, 2011-11-24 23:36:22]

On 2011/11/24 23:16:02, John Abd-El-Malek wrote:
>
http://codereview.chromium.org/8689012/diff/2002/content/browser/gamepad/game...
> File content/browser/gamepad/gamepad_provider.cc (right):
> 
>
http://codereview.chromium.org/8689012/diff/2002/content/browser/gamepad/game...
> content/browser/gamepad/gamepad_provider.cc:101:
> base::ThreadRestrictions::ScopedAllowIO allow_io;
> hmm, no way to avoid this in this cl? these usage tend to creep in and be low
> priority to remove :)

ok, will remove from this cl and work on that separately since it's really
unrelated anyway.

[scottmg, 2011-11-24 23:54:51]

http://codereview.chromium.org/8689012/diff/2002/content/browser/renderer_hos...
File content/browser/renderer_host/gamepad_browser_message_filter.cc (right):

http://codereview.chromium.org/8689012/diff/2002/content/browser/renderer_hos...
content/browser/renderer_host/gamepad_browser_message_filter.cc:22:
IPC_MESSAGE_HANDLER_DELAY_REPLY(GamepadHostMsg_StartPolling,
On 2011/11/24 23:16:02, John Abd-El-Malek wrote:
> you only need to use IPC_MESSAGE_HANDLER_DELAY_REPLY when the sync message
can't
> be responded to in the dispatcher function. in these cases, you don't need it
> since you always have the result ready. see
>
http://www.chromium.org/developers/design-documents/inter-process-communication

Done. (and sweet, much tidier!)

http://codereview.chromium.org/8689012/diff/2002/content/browser/renderer_hos...
File content/browser/renderer_host/gamepad_browser_message_filter.h (right):

http://codereview.chromium.org/8689012/diff/2002/content/browser/renderer_hos...
content/browser/renderer_host/gamepad_browser_message_filter.h:13: : public
BrowserMessageFilter {
On 2011/11/24 23:16:02, John Abd-El-Malek wrote:
> nit: can fit on one line

Done.

http://codereview.chromium.org/8689012/diff/2002/content/browser/renderer_hos...
content/browser/renderer_host/gamepad_browser_message_filter.h:27: };
On 2011/11/24 23:16:02, John Abd-El-Malek wrote:
> nit: add DISALLOW_COPY_AND_ASSIGN

Done.

http://codereview.chromium.org/8689012/diff/2002/content/content_browser.gypi
File content/content_browser.gypi (right):

http://codereview.chromium.org/8689012/diff/2002/content/content_browser.gypi...
content/content_browser.gypi:371:
'browser/renderer_host/gamepad_browser_message_filter.cc',
On 2011/11/24 23:16:02, John Abd-El-Malek wrote:
> nit: order

Done.

[jam, 2011-11-25 18:49:15]

lgtm

[commit-bot: I haz the power, 2011-11-25 19:30:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/8689012/5011

[commit-bot: I haz the power, 2011-11-25 20:51:32]

Try job failure for 8689012-5011 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-25 20:57:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/8689012/5011

[commit-bot: I haz the power, 2011-11-25 22:33:12]

Try job failure for 8689012-5011 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-26 00:22:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scottmg@chromium.org/8689012/5011

[commit-bot: I haz the power, 2011-11-26 01:58:59]

Change committed as 111624

[Avi (use Gerrit), 2011-11-28 20:55:45]

http://codereview.chromium.org/8689012/diff/5011/content/browser/renderer_hos...
File content/browser/renderer_host/gamepad_browser_message_filter.h (right):

http://codereview.chromium.org/8689012/diff/5011/content/browser/renderer_hos...
content/browser/renderer_host/gamepad_browser_message_filter.h:16: bool*
message_was_ok);
In the future, please mark overriding functions with OVERRIDE. (I'll fix this
one.)