Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(918)

Issue 8689010: Remove 1 static initializer and some unused code. (Closed)

Created:
9 years, 1 month ago by Nico
Modified:
9 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Remove 1 static initializer and some unused code. BUG=94925 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111561

Patch Set 1 #

Patch Set 2 : comments? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -27 lines) Patch
M chrome/browser/diagnostics/diagnostics_main.cc View 1 5 chunks +11 lines, -27 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ryan Sleevi
This feels like it strays from being a trivial clean-up to perhaps diverging interfaces - ...
9 years, 1 month ago (2011-11-24 21:52:05 UTC) #1
Nico
Better now? It's still an interface change, but it's nicer. I'm fine with waiting for ...
9 years, 1 month ago (2011-11-24 22:01:54 UTC) #2
Ryan Sleevi
LGTM, thanks
9 years, 1 month ago (2011-11-24 22:05:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/8689010/3001
9 years, 1 month ago (2011-11-24 22:07:41 UTC) #4
commit-bot: I haz the power
9 years, 1 month ago (2011-11-24 23:14:09 UTC) #5
Change committed as 111561

Powered by Google App Engine
This is Rietveld 408576698