Issue 8689009: Moving the include rule for jingle/glue from content/renderer/p2p to content/renderer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8689009: Moving the include rule for jingle/glue from content/renderer/p2p to content/renderer. (Closed)

Created:
9 years, 1 month ago by tommi (sloooow) - chröme

Modified:
9 years, 1 month ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, dpranke-watch+content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Moving the include rule for jingle/glue from content/renderer/p2p to content/renderer. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111557

Patch Set 2 : '' #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	content/renderer/DEPS	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
	M	content/renderer/p2p/DEPS	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm http://codereview.chromium.org/8689009/diff/1/content/renderer/p2p/DEPS File content/renderer/p2p/DEPS (right): http://codereview.chromium.org/8689009/diff/1/content/renderer/p2p/DEPS#newcode1 content/renderer/p2p/DEPS:1: include_rules = [ nit: just remove this file ...

9 years, 1 month ago (2011-11-24 21:14:26 UTC) #2

tommi (sloooow) - chröme

9 years, 1 month ago (2011-11-24 21:19:37 UTC) #3

http://codereview.chromium.org/8689009/diff/1/content/renderer/p2p/DEPS
File content/renderer/p2p/DEPS (right):

http://codereview.chromium.org/8689009/diff/1/content/renderer/p2p/DEPS#newcode1
content/renderer/p2p/DEPS:1: include_rules = [
On 2011/11/24 21:14:26, John Abd-El-Malek wrote:
> nit: just remove this file now

Done.

Expand Messages | Collapse Messages

Issue 8689009: Moving the include rule for jingle/glue from content/renderer/p2p to content/renderer. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages