Issue 8689007: Defend against deleting the default search provider when merging duplicate TURLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8689007: Defend against deleting the default search provider when merging duplicate TURLs. (Closed)

Created:
9 years ago by SteveT

Modified:
9 years ago

Reviewers:
Nicolas Zea

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Defend against deleting the default search provider when merging duplicate TURLs. Added a unit test to check such a scenario. BUG=105391 TEST=Ensure that all TemplateURLServiceSyncTest unit tests succeed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112773

Patch Set 1 #

Created: 9 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -4 lines)			Patch
	M	chrome/browser/search_engines/template_url_service.cc	View		1 chunk	+16 lines, -4 lines	0 comments	Download
	M	chrome/browser/search_engines/template_url_service_sync_unittest.cc	View		1 chunk	+20 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/8689007/1

9 years ago (2011-12-02 18:48:47 UTC) #4

Change committed as 112773

Expand Messages | Collapse Messages