Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3669)

Unified Diff: chrome/browser/resources/sync_setup_overlay.js

Issue 8689006: Create a field test for sync sign in promo strings. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Init Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/sync_setup_overlay.js
===================================================================
--- chrome/browser/resources/sync_setup_overlay.js (revision 111699)
+++ chrome/browser/resources/sync_setup_overlay.js (working copy)
@@ -732,6 +732,16 @@
return false;
},
+ populatePromoMessage_: function(resName) {
+ // Fetch the strings associated with |resName| and set it if it's not
+ // empty. If it's empty, we'll stick with the default text.
+ var text = localStrings.getString(resName);
+ if (!text || !text.length) {
+ return;
+ }
+ $('sync-setup-login-promo-body').textContent = text;
+ },
+
setErrorVisibility_: function() {
this.resetErrorVisibility_();
var f = $('gaia-login-form');
@@ -882,6 +892,10 @@
SyncSetupOverlay.getInstance().showStopSyncingUI_();
};
+ SyncSetupOverlay.populatePromoMessage = function(resName) {
+ SyncSetupOverlay.getInstance().populatePromoMessage_(resName);
+ };
+
// Export
return {
SyncSetupOverlay: SyncSetupOverlay

Powered by Google App Engine
This is Rietveld 408576698