Reland 111519: Remove default plug-in on Mac, Gtk and Aura.

Reland 111519: Remove default plug-in on Mac, Gtk and Aura.

Aura doesn't do plug-ins, and Mac and Gtk already use in-renderer placeholders.

TBR=jam@chromium.org
BUG=62079
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111590

[Bernhard Bauer, 2011-11-24 13:09:03]

Please review.

The old version is patch set 0, for comparison.

[Bernhard Bauer, 2011-11-24 13:09:20]

On 2011/11/24 13:09:03, Bernhard Bauer wrote:
> Please review.
> 
> The old version is patch set 0, for comparison.

Patch set 1, I meant. Zero-based indexing ;-)

[jochen (gone - plz use gerrit), 2011-11-24 13:17:37]

http://codereview.chromium.org/8689001/diff/2001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/8689001/diff/2001/chrome/chrome_tests.gypi#new...
chrome/chrome_tests.gypi:844: 'browser/default_plugin_uitest.cc',
not sure I understand this. You deleted the entry above, and you also put it on
the exclusion list for aura?

Shouldn't you put it on the inclusion list for not-aura?

[Bernhard Bauer, 2011-11-24 13:53:04]

http://codereview.chromium.org/8689001/diff/2001/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/8689001/diff/2001/chrome/chrome_tests.gypi#new...
chrome/chrome_tests.gypi:844: 'browser/default_plugin_uitest.cc',
On 2011/11/24 13:17:38, jochen wrote:
> not sure I understand this. You deleted the entry above, and you also put it
on
> the exclusion list for aura?
> 
> Shouldn't you put it on the inclusion list for not-aura?

True, that seems like one too many ;-) I think the more common pattern is to
list it under sources, then exclude it conditionally, so I'm going with that
now.

[jochen (gone - plz use gerrit), 2011-11-24 13:59:12]

lgtm pending trybot happiness

[commit-bot: I haz the power, 2011-11-25 08:39:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/8689001/7001

[commit-bot: I haz the power, 2011-11-25 10:06:53]

Try job failure for 8689001-7001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-25 10:18:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/8689001/7001

[commit-bot: I haz the power, 2011-11-25 11:39:44]

Try job failure for 8689001-7001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2011-11-25 11:51:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bauerb@chromium.org/8689001/7001

[commit-bot: I haz the power, 2011-11-25 13:08:40]

Try job failure for 8689001-7001 (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...